Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Optimize] Fix bundlesPath by resolving optimize dir #14309

Merged
merged 3 commits into from
Oct 4, 2017
Merged

[Optimize] Fix bundlesPath by resolving optimize dir #14309

merged 3 commits into from
Oct 4, 2017

Conversation

rhoboat
Copy link

@rhoboat rhoboat commented Oct 4, 2017

Addresses #14295

@rhoboat rhoboat self-assigned this Oct 4, 2017
@jbudz
Copy link
Member

jbudz commented Oct 4, 2017

should this be doing ${pwd}../../optimize?

@rhoboat rhoboat changed the title [Optimize] Fix bundlesPath by prefixing optimize.bundleDir with slash [Optimize] Fix bundlesPath by resolving optimize dir Oct 4, 2017
@rhoboat
Copy link
Author

rhoboat commented Oct 4, 2017

@spalger ready again

spalger
spalger approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhoboat rhoboat added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.1.0 v7.0.0 review labels Oct 4, 2017
@rhoboat
Copy link
Author

rhoboat commented Oct 4, 2017

@jbudz yep, i was missing the __dirname argument. you had the right idea

@jbudz
Copy link
Member

jbudz commented Oct 4, 2017

cool, unsolicited lgtm

@rhoboat rhoboat merged commit 1fb8c82 into elastic:master Oct 4, 2017
@rhoboat rhoboat deleted the fix-bundlespath branch October 4, 2017 20:33
rhoboat pushed a commit that referenced this pull request Oct 4, 2017
@archanid
[Optimize] Fix bundlesPath by resolving optimize dir (#14309)
e6b6d22 
* [Optimize] Fix bundlesPath by prefixing optimize.bundleDir with slash

* [Optimize] Fix bundlesPath by resolving optimize dir

* [Optimize] Fix bundlesPath by resolving optimize dir
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017
@archanid @chrisronline
[Optimize] Fix bundlesPath by resolving optimize dir (elastic#14309)
e6173c7 
* [Optimize] Fix bundlesPath by prefixing optimize.bundleDir with slash

* [Optimize] Fix bundlesPath by resolving optimize dir

* [Optimize] Fix bundlesPath by resolving optimize dir
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017
@archanid @chrisronline
[Optimize] Fix bundlesPath by resolving optimize dir (elastic#14309)
4ac85fd 
* [Optimize] Fix bundlesPath by prefixing optimize.bundleDir with slash

* [Optimize] Fix bundlesPath by resolving optimize dir

* [Optimize] Fix bundlesPath by resolving optimize dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

@chrisronline chrisronline Awaiting requested review from chrisronline

Assignees

@rhoboat rhoboat

Labels
review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.1.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhoboat @jbudz @spalger