[ts/checkProjects] validate extends of all ts projects #145176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Nov 15, 2022
mistic
approved these changes
Nov 15, 2022
sebelga
approved these changes
Nov 15, 2022
pgayvallet
approved these changes
Nov 16, 2022
kibanamachine
added
v8.6.0
backport:skip
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Nov 17, 2022
Fixes elastic#145129 In order to make our TS setup in the repo far more efficient we needed to make it a little more complicated than it used to be. This includes a few rules that all tsconfig files need to follow which were currently assumed to be true, but with this PR will now be validated: 1. No tsconfig.json files are allowed to extend the `tsconfig.json` file. This file is used to produce types for the root of the repo, and include the `package.json` file in a project so it can be referenced in projects directly. Files which violate this rule were updated to point to the root `tsconfig.base.json` file. 2. Every tsconfig.json file must extend the `tsconfig.base.json` file, either directly or indirectly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145129
In order to make our TS setup in the repo far more efficient we needed to make it a little more complicated than it used to be. This includes a few rules that all tsconfig files need to follow which were currently assumed to be true, but with this PR will now be validated:
tsconfig.jsonfile. This file is used to produce types for the root of the repo, and include thepackage.jsonfile in a project so it can be referenced in projects directly. Files which violate this rule were updated to point to the roottsconfig.base.jsonfile.tsconfig.base.jsonfile, either directly or indirectly.