Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix theme for Alerts popover #145390

Merged
merged 10 commits into from
Nov 17, 2022
Merged

[Discover] Fix theme for Alerts popover #145390

merged 10 commits into from
Nov 17, 2022

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Nov 16, 2022 •
edited by kibanamachine
Loading

Closes #143070

Summary

This PR adds theme provider to the Alerts popover.

Dark theme:
Screenshot 2022-11-16 at 16 37 49

Light theme:
Screenshot 2022-11-16 at 16 38 17

@jughosta jughosta added release_note:fix Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 16, 2022
@jughosta jughosta self-assigned this Nov 16, 2022
@jughosta jughosta marked this pull request as ready for review November 16, 2022 15:47
@jughosta jughosta requested a review from a team as a code owner November 16, 2022 15:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal
kertal approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx for making it dark as the ☕ I'm soon gonna drink! tested locally, and works as expected 👍
Bildschirmfoto 2022-11-17 um 14 25 06

src/plugins/discover/public/application/main/components/top_nav/open_alerts_popover.tsx Outdated Show resolved Hide resolved
@jughosta jughosta enabled auto-merge (squash) November 17, 2022 15:58
@jughosta
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 414.3KB 414.4KB +84.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta merged commit e33392b into elastic:main Nov 17, 2022
@kibanamachine kibanamachine mentioned this pull request Nov 17, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 17, 2022
@jughosta
[Discover] Fix theme for Alerts popover (elastic#145390)
8347e91 
Closes elastic#143070

## Summary

This PR adds theme provider to the Alerts popover.

Dark theme:
<img width="534" alt="Screenshot 2022-11-16 at 16 37 49"
src="https://user-images.githubusercontent.com/1415710/202226249-a46f6608-4f35-40ce-bfbf-847e9a7ba81a.png">

Light theme:
<img width="531" alt="Screenshot 2022-11-16 at 16 38 17"
src="https://user-images.githubusercontent.com/1415710/202226260-9e67a8dd-f6a4-40ff-ae28-2691b9a082bf.png">

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
(cherry picked from commit e33392b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 17, 2022
@kibanamachine @jughosta
[8.6] [Discover] Fix theme for Alerts popover (#145390) (#145631)
520e876 
# Backport

This will backport the following commits from `main` to `8.6`:
- [[Discover] Fix theme for Alerts popover
(#145390)](#145390)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2022-11-17T21:32:39Z","message":"[Discover]
Fix theme for Alerts popover (#145390)\n\nCloses
https://github.com/elastic/kibana/issues/143070\r\n\r\n##
Summary\r\n\r\nThis PR adds theme provider to the Alerts
popover.\r\n\r\nDark theme:\r\n<img width=\"534\" alt=\"Screenshot
2022-11-16 at 16 37
49\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/202226249-a46f6608-4f35-40ce-bfbf-847e9a7ba81a.png\">\r\n\r\nLight
theme:\r\n<img width=\"531\" alt=\"Screenshot 2022-11-16 at 16 38
17\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/202226260-9e67a8dd-f6a4-40ff-ae28-2691b9a082bf.png\">\r\n\r\nCo-authored-by:
Matthias Wilhelm
<ankertal@gmail.com>","sha":"e33392bff0a022bb246f8d560a336ebdac0555f9","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:prev-minor","v8.7.0"],"number":145390,"url":"https://github.com/elastic/kibana/pull/145390","mergeCommit":{"message":"[Discover]
Fix theme for Alerts popover (#145390)\n\nCloses
https://github.com/elastic/kibana/issues/143070\r\n\r\n##
Summary\r\n\r\nThis PR adds theme provider to the Alerts
popover.\r\n\r\nDark theme:\r\n<img width=\"534\" alt=\"Screenshot
2022-11-16 at 16 37
49\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/202226249-a46f6608-4f35-40ce-bfbf-847e9a7ba81a.png\">\r\n\r\nLight
theme:\r\n<img width=\"531\" alt=\"Screenshot 2022-11-16 at 16 38
17\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/202226260-9e67a8dd-f6a4-40ff-ae28-2691b9a082bf.png\">\r\n\r\nCo-authored-by:
Matthias Wilhelm
<ankertal@gmail.com>","sha":"e33392bff0a022bb246f8d560a336ebdac0555f9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145390","number":145390,"mergeCommit":{"message":"[Discover]
Fix theme for Alerts popover (#145390)\n\nCloses
https://github.com/elastic/kibana/issues/143070\r\n\r\n##
Summary\r\n\r\nThis PR adds theme provider to the Alerts
popover.\r\n\r\nDark theme:\r\n<img width=\"534\" alt=\"Screenshot
2022-11-16 at 16 37
49\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/202226249-a46f6608-4f35-40ce-bfbf-847e9a7ba81a.png\">\r\n\r\nLight
theme:\r\n<img width=\"531\" alt=\"Screenshot 2022-11-16 at 16 38
17\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/202226260-9e67a8dd-f6a4-40ff-ae28-2691b9a082bf.png\">\r\n\r\nCo-authored-by:
Matthias Wilhelm
<ankertal@gmail.com>","sha":"e33392bff0a022bb246f8d560a336ebdac0555f9"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees

@jughosta jughosta

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:fix Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alerts menu in discover main nav doesn't have darktheme
5 participants
@jughosta @elasticmachine @kibana-ci @kibanamachine @kertal