Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.6] [Alert Summaries] [BE] Move “Notify When” and throttle from rule to action (#144130) #145469

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.6:

Questions ?

Please refer to the Backport tool documentation

…ction (elastic#144130)

* Add frequency props to actions and validate them on edit/create

* Nullify undefined throttle

* Update schema to allow for frequency param on actions

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Commit missing file

* Fix types

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Fix types

* Fix jest

* Fix validating global freq params

* Add tests for create and edit

* Reset legacy api

* Make notify and throttle optional in route schemas

* Fix tests

* Split missing frequency test cases

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0c864fe)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
alerting 406 408 +2
triggersActionsUi 501 502 +1
total +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
alerting 39.2KB 39.2KB +57.0B
Unknown metric groups

API count

id before after diff
alerting 415 417 +2
triggersActionsUi 530 531 +1
total +3

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Zacqary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants