[8.5] [Security Solution][Bug fix] alerts table over 10k results (#145441) #145481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…45441) This PR aims to address: - elastic#142965 ### Background On Alerts page -> Events table -> Event Rendered view, when there are over 10,000 alerts, upon clicking the last page, a warning message appears. <img width="800" alt="image" src="https://user-images.githubusercontent.com/18648970/202265598-5d9d657c-4918-408e-9f92-bcaafc904757.png"> The pop up is expected behavior according to documentation from: https://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html . > By default, you cannot use from and size to page through more than 10,000 hits. This limit is a safeguard set by the [index.max_result_window](https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window) index setting. ### After Currently the Grid view has a safeguard in place, where if there are more than 10k results, it will not show the last page, hence preventing user from clicking it and seeing the error pop up. - This PR applies the same approach by wrapping the `EventRenderView` component with the `EuiDataGridContainer`. - This PR also renamed `EuiDataGridContainer` to `EuiEventTableContainer` to indicate broader use. When there are over 10k records, last page is not available in pagination, and it is the same in Event Rendered View as in Grid view: https://user-images.githubusercontent.com/18648970/202271379-309cbb3c-5da6-4c46-9814-beeca39d1f36.mov (cherry picked from commit 3c77ec0)
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.5:Questions ?
Please refer to the Backport tool documentation