[Enterprise Search] Localize a couple numbers in connector document list #145559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
force-pushed
the
ent-search-3106-localize-number
branch
from
a1d5c79
to
b2d4d09
Compare
|
@elasticmachine merge upstream |
TattdCodeMonkey
approved these changes
Nov 17, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 17, 2022
…ist (elastic#145559) This adds some localization for previously unlocalized text and numbers on the connector documents page. (cherry picked from commit 1cf1de3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2022
…ment list (#145559) (#145597) # Backport This will backport the following commits from `main` to `8.6`: - [[Enterprise Search] Localize a couple numbers in connector document list (#145559)](#145559) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-17T17:02:19Z","message":"[Enterprise Search] Localize a couple numbers in connector document list (#145559)\n\nThis adds some localization for previously unlocalized text and numbers\r\non the connector documents page.","sha":"1cf1de3c71e10a43a5369b8d5950d64081c0a7f0","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:EnterpriseSearch","v8.6.0","v8.7.0"],"number":145559,"url":"https://github.com/elastic/kibana/pull/145559","mergeCommit":{"message":"[Enterprise Search] Localize a couple numbers in connector document list (#145559)\n\nThis adds some localization for previously unlocalized text and numbers\r\non the connector documents page.","sha":"1cf1de3c71e10a43a5369b8d5950d64081c0a7f0"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145559","number":145559,"mergeCommit":{"message":"[Enterprise Search] Localize a couple numbers in connector document list (#145559)\n\nThis adds some localization for previously unlocalized text and numbers\r\non the connector documents page.","sha":"1cf1de3c71e10a43a5369b8d5950d64081c0a7f0"}}]}] BACKPORT--> Co-authored-by: Sander Philipse <94373878+sphilipse@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some localization for previously unlocalized text and numbers on the connector documents page.