[Security Solution] [Rules] Fixes bug where editing a rule with a data view throws an unhandled exception #145658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhurley14
commented
Nov 23, 2022
Comment on lines
+506
to
+508
| return kibanaDataViews == null || Object.keys(kibanaDataViews).length === 0 ? ( | ||
| <EuiLoadingSpinner size="l" /> | ||
| ) : ( |
There was a problem hiding this comment.
unsure why the kibanaDataViews passed down to the edit page started breaking the edit page this release compared to last release. Either way, this will fix the issue going forward.
dhurley14
changed the title
dhurley14
added
review
release_note:skip
xcrzx
approved these changes
Nov 23, 2022
| @@ -158,5 +165,24 @@ describe('Custom query rules', () => { | |||
| .should('match', /^[1-9].+$/); | |||
| cy.get(ALERT_GRID_CELL).contains(this.rule.name); | |||
| }); | |||
| it('Creates and edits a new rule with a data view', function () { | |||
| visit(RULE_CREATION); | |||
| fillDefineCustomRuleAndContinue(this.rule); | |||
There was a problem hiding this comment.
Not related to this PR, but I've noticed that we access rules in our Cypress tests via this. And that leads to the type of this.rule being any. @dhurley14 Do you happen to know why we access rules using this?
There was a problem hiding this comment.
That's a good question. It's not clear to me either. @MadameSheema?
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @dhurley14 |
dhurley14
added
the
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 23, 2022
…a view throws an unhandled exception (elastic#145658) ## Summary Ref: elastic#145078 (cherry picked from commit 584752f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 23, 2022
… a data view throws an unhandled exception (#145658) (#146153) # Backport This will backport the following commits from `main` to `8.6`: - [[Security Solution] [Rules] Fixes bug where editing a rule with a data view throws an unhandled exception (#145658)](#145658) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Devin W. Hurley","email":"devin.hurley@elastic.co"},"sourceCommit":{"committedDate":"2022-11-23T14:11:05Z","message":"[Security Solution] [Rules] Fixes bug where editing a rule with a data view throws an unhandled exception (#145658)\n\n## Summary\r\n\r\nRef: https://github.com/elastic/kibana/issues/145078","sha":"584752f36693d2e9af56605f2e914285a1d4d62d","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","Team:Security Solution Platform","Feature:Rule Details","backport:prev-minor","v8.6.0","v8.7.0"],"number":145658,"url":"https://github.com/elastic/kibana/pull/145658","mergeCommit":{"message":"[Security Solution] [Rules] Fixes bug where editing a rule with a data view throws an unhandled exception (#145658)\n\n## Summary\r\n\r\nRef: https://github.com/elastic/kibana/issues/145078","sha":"584752f36693d2e9af56605f2e914285a1d4d62d"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145658","number":145658,"mergeCommit":{"message":"[Security Solution] [Rules] Fixes bug where editing a rule with a data view throws an unhandled exception (#145658)\n\n## Summary\r\n\r\nRef: https://github.com/elastic/kibana/issues/145078","sha":"584752f36693d2e9af56605f2e914285a1d4d62d"}}]}] BACKPORT--> Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref: #145078
I was unable to track down the reason as to why this error started appearing in 8.6 but this fix resolves the issue.
Checklist
Delete any items that are not applicable to this PR.