Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix Rules and Connectors app labels #145660

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 18, 2022

Summary

Relates to #143809

This PR updates the documentation to use the appropriate "Rules" or "Connectors" app name, now that there's no longer a "Rules and Connectors" app. It uses attributes from https://github.com/elastic/docs/blob/master/shared/attributes.asciidoc in case the names change again in the future. It also includes some minor edits on the pages.

@github-actions
Copy link
Contributor

Documentation preview:

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Nov 18, 2022
@lcawl lcawl marked this pull request as draft November 18, 2022 16:33
@lcawl lcawl marked this pull request as ready for review November 18, 2022 18:11
@lcawl lcawl changed the title [DOCS] Fix app labels [DOCS] Fix Rules and Connectors app labels Nov 18, 2022
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit 8086e99 into elastic:main Nov 22, 2022
@lcawl lcawl deleted the rac-labels branch November 22, 2022 17:14
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 22, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 22, 2022
# Backport

This will backport the following commits from `main` to `8.6`:
- [[DOCS] Fix Rules and Connectors app labels
(#145660)](#145660)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2022-11-22T17:14:31Z","message":"[DOCS]
Fix Rules and Connectors app labels
(#145660)","sha":"8086e99478920df7d6230016364fe2df13cd03d6","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","Feature:Alerting/RulesManagement","v8.6.0","v8.7.0"],"number":145660,"url":"https://github.com/elastic/kibana/pull/145660","mergeCommit":{"message":"[DOCS]
Fix Rules and Connectors app labels
(#145660)","sha":"8086e99478920df7d6230016364fe2df13cd03d6"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145660","number":145660,"mergeCommit":{"message":"[DOCS]
Fix Rules and Connectors app labels
(#145660)","sha":"8086e99478920df7d6230016364fe2df13cd03d6"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.6.0 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants