Fix exceptions_success_count relate only to exceptions items #145700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkhristinin
added
release_note:skip
|
@elasticmachine merge upstream |
maximpn
approved these changes
Nov 21, 2022
| @@ -43,7 +43,7 @@ export const importRuleExceptions = async ({ | |||
| const { | |||
| errors, | |||
| success, | |||
| success_count: successCount, | |||
| success_count_exception_list_items: successCount, | |||
There was a problem hiding this comment.
It would be nice to have a comment why success_count_exception_list_items is used instead of success_count. Otherwise it may raise questions later on.
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
vitaliidm
approved these changes
Nov 22, 2022
| @@ -43,7 +43,9 @@ export const importRuleExceptions = async ({ | |||
| const { | |||
| errors, | |||
| success, | |||
| success_count: successCount, | |||
| // return only count of exception list items, without count excpetions list | |||
There was a problem hiding this comment.
Suggested change
| // return only count of exception list items, without count excpetions list | |
| // return only count of exception list items, without count exceptions list |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2022
…#145700) ## Fix import rules success message fix elastic#136760 exceptions_success_count now don't count exceptions list, only exceptions list items After discussion with the team, that is ok to return only exceptions list items as success_count for the rule import, because it reflects our UI. It does not really reflect the backend, because we also have the exceptions list container. https://user-images.githubusercontent.com/7609147/202669384-5ddda1a7-e832-41a9-b899-5473a8188681.mov Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 93e0cf5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 23, 2022
…145700) (#146012) # Backport This will backport the following commits from `main` to `8.6`: - [Fix exceptions_success_count relate only to exceptions items (#145700)](#145700) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Khristinin Nikita","email":"nikita.khristinin@elastic.co"},"sourceCommit":{"committedDate":"2022-11-22T15:51:54Z","message":"Fix exceptions_success_count relate only to exceptions items (#145700)\n\n## Fix import rules success message\r\n\r\nfix https://github.com/elastic/kibana/issues/136760\r\n\r\nexceptions_success_count now don't count exceptions list, only\r\nexceptions list items\r\n\r\nAfter discussion with the team, that is ok to return only exceptions\r\nlist items as success_count for the rule import, because it reflects our\r\nUI. It does not really reflect the backend, because we also have the\r\nexceptions list container.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/7609147/202669384-5ddda1a7-e832-41a9-b899-5473a8188681.mov\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"93e0cf5a34bd5aef5a2be6cb8d43c8f9597e3b02","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Security Solution Platform","backport:prev-minor","v8.7.0"],"number":145700,"url":"https://github.com/elastic/kibana/pull/145700","mergeCommit":{"message":"Fix exceptions_success_count relate only to exceptions items (#145700)\n\n## Fix import rules success message\r\n\r\nfix https://github.com/elastic/kibana/issues/136760\r\n\r\nexceptions_success_count now don't count exceptions list, only\r\nexceptions list items\r\n\r\nAfter discussion with the team, that is ok to return only exceptions\r\nlist items as success_count for the rule import, because it reflects our\r\nUI. It does not really reflect the backend, because we also have the\r\nexceptions list container.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/7609147/202669384-5ddda1a7-e832-41a9-b899-5473a8188681.mov\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"93e0cf5a34bd5aef5a2be6cb8d43c8f9597e3b02"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145700","number":145700,"mergeCommit":{"message":"Fix exceptions_success_count relate only to exceptions items (#145700)\n\n## Fix import rules success message\r\n\r\nfix https://github.com/elastic/kibana/issues/136760\r\n\r\nexceptions_success_count now don't count exceptions list, only\r\nexceptions list items\r\n\r\nAfter discussion with the team, that is ok to return only exceptions\r\nlist items as success_count for the rule import, because it reflects our\r\nUI. It does not really reflect the backend, because we also have the\r\nexceptions list container.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/7609147/202669384-5ddda1a7-e832-41a9-b899-5473a8188681.mov\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"93e0cf5a34bd5aef5a2be6cb8d43c8f9597e3b02"}}]}] BACKPORT--> Co-authored-by: Khristinin Nikita <nikita.khristinin@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix import rules success message
fix #136760
exceptions_success_count now don't count exceptions list, only exceptions list items
After discussion with the team, that is ok to return only exceptions list items as success_count for the rule import, because it reflects our UI. It does not really reflect the backend, because we also have the exceptions list container.
Screen.Recording.2022-11-18.at.10.32.39.mov