[8.6] [Actionable observability] Validate alert search bar query parameters (#145369) #145702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elastic#145369) Fixes elastic#144911, elastic#143640 ## 📝 Summary - Validate alert search bar query params using io-ts - Make sure that we only enter one history for changes related to the alert search bar - Make sure to not save tab changes on the rule details page in the history - Use `DatePickerContextProvider` only for `overview` page to fix 143640 ## 🧪 How to test - In the alerts page URL, you should not see `rangeFrom=now-15m&rangeTo=now` query parameters anymore - Changing the alerts' page URL to an invalid one should not break the page anymore - Example: `_a=(kuery:%27%27,rangeFrom:now-15m,rangeTo:12)` - By changing alert search bar information, you should not see new records added to the history - Same for rule details page (either changing tab or alert search bar parameters) (cherry picked from commit 42a1062)
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.6:Questions ?
Please refer to the Backport tool documentation