Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move data_views related codeownership to kibana-data-discovery #145706

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Move data_views related codeownership to kibana-data-discovery #145706

merged 1 commit into from
Nov 18, 2022

Conversation

kertal
Copy link
Member

@kertal kertal commented Nov 18, 2022

Summary

This PR moves `data_views' related codeownership to the data discovery team. Welcome!

@kertal kertal added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) labels Nov 18, 2022
@kertal kertal self-assigned this Nov 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added v8.7.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Nov 18, 2022
@kertal kertal requested review from a team November 18, 2022 10:43
Dosant
Dosant approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😿

.github/CODEOWNERS Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 442 448 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 519 525 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

mattkime
mattkime approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kertal kertal merged commit ab2eb9d into elastic:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

@mattkime mattkime mattkime approved these changes

@jughosta jughosta jughosta approved these changes

Assignees

@kertal kertal

Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kertal @elasticmachine @kibana-ci @mattkime @jughosta @Dosant