Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix anomaly detection jobs list not refreshing #145757

Merged
merged 2 commits into from
Nov 22, 2022
Merged

[ML] Fix anomaly detection jobs list not refreshing #145757

merged 2 commits into from
Nov 22, 2022

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Nov 18, 2022 •
edited by kibanamachine
Loading

Fixes #144529

Removes the blockRefresh prop which is no longer needed since the page refresh controls trigger a whole re-render of the JobsPage component.

@jgowdyelastic jgowdyelastic self-assigned this Nov 18, 2022
@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience release_note:fix :ml Feature:Anomaly Detection ML anomaly detection v8.6.0 v8.7.0 labels Nov 18, 2022
@jgowdyelastic jgowdyelastic marked this pull request as ready for review November 18, 2022 16:51
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner November 18, 2022 16:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB -24.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 442 448 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 110 117 +7
securitySolution 519 525 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

alvarezmelissa87
alvarezmelissa87 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and local test seems to work as expected ⚡

peteharverson
peteharverson approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit c520869 into elastic:main Nov 22, 2022
@jgowdyelastic jgowdyelastic deleted the fix-ad-jobs-list-not-refreshing branch November 22, 2022 10:53
@kibanamachine kibanamachine mentioned this pull request Nov 22, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 22, 2022
@jgowdyelastic
[ML] Fix anomaly detection jobs list not refreshing (elastic#145757)
f1d7095 
Fixes elastic#144529

Removes the `blockRefresh` prop which is no longer needed since the page
refresh controls trigger a whole re-render of the `JobsPage` component.

(cherry picked from commit c520869)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 22, 2022
@kibanamachine @jgowdyelastic
[8.6] [ML] Fix anomaly detection jobs list not refreshing (#145757) (#…
6dfa1dd 
…145971)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[ML] Fix anomaly detection jobs list not refreshing
(#145757)](#145757)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2022-11-22T10:53:18Z","message":"[ML]
Fix anomaly detection jobs list not refreshing (#145757)\n\nFixes
https://github.com/elastic/kibana/issues/144529\r\n\r\nRemoves the
`blockRefresh` prop which is no longer needed since the page\r\nrefresh
controls trigger a whole re-render of the `JobsPage`
component.","sha":"c5208695a9fc7c88de781500179864141ca99098","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:Anomaly
Detection","v8.6.0","v8.7.0"],"number":145757,"url":"https://github.com/elastic/kibana/pull/145757","mergeCommit":{"message":"[ML]
Fix anomaly detection jobs list not refreshing (#145757)\n\nFixes
https://github.com/elastic/kibana/issues/144529\r\n\r\nRemoves the
`blockRefresh` prop which is no longer needed since the page\r\nrefresh
controls trigger a whole re-render of the `JobsPage`
component.","sha":"c5208695a9fc7c88de781500179864141ca99098"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145757","number":145757,"mergeCommit":{"message":"[ML]
Fix anomaly detection jobs list not refreshing (#145757)\n\nFixes
https://github.com/elastic/kibana/issues/144529\r\n\r\nRemoves the
`blockRefresh` prop which is no longer needed since the page\r\nrefresh
controls trigger a whole re-render of the `JobsPage`
component.","sha":"c5208695a9fc7c88de781500179864141ca99098"}}]}]
BACKPORT-->

Co-authored-by: James Gowdy <jgowdy@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Anomaly detection job list refresh button broken
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @alvarezmelissa87 @peteharverson