[Cases] Enhance labels in the bulk edit tags flyout #145811

cnasikas · 2022-11-21T08:47:55Z

Summary

This PR a) fixes the label when there are no tags, b) adds a label when there are no matches, c) removes a useEffect which is not necessary anymore, and d) shortens the help text for the tags field.

Fixes: #145214

Screenshots

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2022-11-21T08:47:58Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2022-11-21T08:47:59Z

Pinging @elastic/response-ops-cases (Feature:Cases)

adcoelho

This works for me and the issue seems fixed.

However, I was playing around with the tags while testing and noticed that in the flyout we display the text:

Add whatever as a tag - as a tag

But if we try to add a tag in the case creation or in the case detail views, the text is

Add whatever as a custom option - as a custom option

It's not a big deal but maybe we could make these consistent in this PR?

Case creation

Case Detail

Otherwise, looks good to me 👍

mdefazio

Placement of the text works for me.

Both texts show for me when I have no tags and open the 'Edit tags' flyout (and before I search anything).

Also, I believe we should avoid using 'Type to...' as an action. 🤔

cnasikas · 2022-11-21T15:20:35Z

Thanks, @adcoelho and @mdefazio! @adcoelho I will update it in this PR.

Also, I believe we should avoid using 'Type to...' as an action. 🤔

@lcawl Any suggestions for the text? I think we should indicate to the users that to add a tag they have to search.

mdefazio

UI changes look good.

lcawl · 2022-11-21T22:50:34Z

x-pack/plugins/cases/public/components/actions/tags/translations.ts

@@ -51,3 +51,11 @@ export const SELECTED_TAGS = (selectedTags: number) =>
    defaultMessage: 'Selected: {selectedTags}',
    values: { selectedTags },
  });
+
+export const NO_TAGS_AVAILABLE = i18n.translate('xpack.cases.actions.tags.noTagsAvailable', {
+  defaultMessage: 'No tags available. Type to add one.',


@lcawl Any suggestions for the text? I think we should indicate to the users that to add a tag they have to search.

I think the piece of info I was missing until I tested this myself was "where" we're asking them to type. I suggest changing the string to something like this:

Suggested change

defaultMessage: 'No tags available. Type to add one.',

defaultMessage: 'No tags available. To add a tag, type it in the query bar.',

Thanks, @lcawl! Sorry, I should explain better.

I received additional feedback from @gchaps recommending "enter" instead of "type":

Suggested change

defaultMessage: 'No tags available. Type to add one.',

defaultMessage: 'No tags available. To add a tag, enter it in the query bar.',

peteharverson · 2022-11-22T13:23:00Z

Changes here LGTM, but taking a look on the case view:

Now that we have user assignee functionality, should we be using the term assigned for tags here? Would No tags are currently added to this case be better @lcawl?

Also have we lost some spacing vertically between the Reporter, Participants and Tags sections @mdefazio ?

cnasikas · 2022-11-22T13:32:28Z

Also have we lost some spacing vertically between the Reporter, Participants and Tags sections @mdefazio ?

I think this has to do with some changes in the EuiFlex family components by the EUI team. Could you please open an issue?

peteharverson · 2022-11-22T15:07:30Z

Also have we lost some spacing vertically between the Reporter, Participants and Tags sections @mdefazio ?

Raised a new issue #146008 for this layout issue in the sidebar.

…-ref HEAD~1..HEAD --fix'

lcawl · 2022-11-22T18:05:31Z

Now that we have user assignee functionality, should we be using the term assigned for tags here? Would No tags are currently added to this case be better @lcawl?

I agree that "assigned" is overloaded now, though I think we still want to follow the layout of the help text for the Assignees section since they're so close. For example:

Was:

Assignees: No users have been assigned.
Tags: No tags are currently assigned to this case.

Should be:

Assignees: No users are assigned.
Tags: No tags are added.

If you want me to add that change as a commit in this PR, @cnasikas, just let me know!

cnasikas · 2022-11-22T18:06:41Z

Thanks Lisa! I will do it.

lcawl · 2022-11-23T00:18:10Z

x-pack/plugins/cases/public/components/actions/tags/translations.ts

+});
+
+export const NO_SEARCH_MATCH = i18n.translate('xpack.cases.actions.tags.noTagsMatch', {
+  defaultMessage: 'No tags available. To add a tag, type it in the query bar.',


I think unless I've missed the discussion thread, this string should remain as it was in the initial commit (i.e. for the case where a search term doesn't match any tags):

Suggested change

defaultMessage: 'No tags available. To add a tag, type it in the query bar.',

defaultMessage: 'No tags match your search.',

lcawl · 2022-11-23T00:19:29Z

x-pack/plugins/cases/public/components/actions/tags/translations.ts

@@ -51,3 +51,11 @@ export const SELECTED_TAGS = (selectedTags: number) =>
    defaultMessage: 'Selected: {selectedTags}',
    values: { selectedTags },
  });
+
+export const NO_TAGS_AVAILABLE = i18n.translate('xpack.cases.actions.tags.noTagsAvailable', {
+  defaultMessage: 'No tags available. Type to add one.',


I received additional feedback from @gchaps recommending "enter" instead of "type":

Suggested change

defaultMessage: 'No tags available. Type to add one.',

defaultMessage: 'No tags available. To add a tag, enter it in the query bar.',

banderror · 2022-11-23T09:15:33Z

x-pack/plugins/security_solution/public/detections/components/rules/step_about_rule/schema.tsx

@@ -28,8 +28,7 @@ export const schema: FormSchema<AboutStepRule> = {
    helpText: i18n.translate(
      'xpack.securitySolution.detectionEngine.createRule.stepAboutRule.fieldAuthorHelpText',
      {
-        defaultMessage:
-          'Type one or more authors for this rule. Press enter after each author to add a new one.',
+        defaultMessage: 'Separate tags with a line break.',


@cnasikas Hey Christos, I believe changes in this file should be reverted, or am I missing something?

@banderror You are right. @lcawl I will revert the changes related to the security solution as it is out of the scope of this PR.

This reverts commit de3a6a4.

kibana-ci · 2022-11-23T12:56:44Z

💚 Build Succeeded

Buildkite Build
Commit: b0fd46a

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	347.4KB	347.3KB	-60.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cases`	127.0KB	127.1KB	+139.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	59	65	+6
`osquery`	109	115	+6
`securitySolution`	443	449	+6
total			+20

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	68	74	+6
`osquery`	110	117	+7
`securitySolution`	520	526	+6
total			+21

History

💚 Build #90075 succeeded c0ffa0e
💚 Build #89901 succeeded 1b2dac7
💚 Build #89794 succeeded 8968c39
💔 Build #89544 failed d54f536
💔 Build #89542 failed cda406f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

## Summary This PR a) fixes the label when there are no tags, b) adds a label when there are no matches, c) removes a `useEffect` which is not necessary anymore, and d) shortens the help text for the tags field. Fixes: elastic#145214 ## Screenshots <img width="640" alt="Screenshot 2022-11-19 at 12 57 50 PM" src="https://user-images.githubusercontent.com/7871006/203005858-e7270771-4aaf-40a6-9174-306bacfb55fd.png"> <img width="639" alt="Screenshot 2022-11-19 at 12 45 55 PM" src="https://user-images.githubusercontent.com/7871006/203005874-6a42eff5-2c28-4962-8b53-58b2eb21b97e.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: lcawl <lcawley@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 6d9811e)

kibanamachine · 2022-11-23T13:02:56Z

💚 All backports created successfully

Status	Branch	Result
✅	8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…146142) # Backport This will backport the following commits from `main` to `8.6`: - [[Cases] Enhance labels in the bulk edit tags flyout (#145811)](#145811)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

cnasikas added 4 commits November 19, 2022 13:28

Fix tags label

61e6454

Move no match text to the top

2ab05a3

Remove hack

fecb27b

Merge branch 'main' into fix_tags_label

cda406f

cnasikas self-assigned this Nov 21, 2022

cnasikas requested a review from a team as a code owner November 21, 2022 08:47

cnasikas requested review from lcawl and mdefazio November 21, 2022 08:53

Fix i18n

d54f536

adcoelho approved these changes Nov 21, 2022

View reviewed changes

mdefazio requested changes Nov 21, 2022

View reviewed changes

PR feedback

8968c39

mdefazio approved these changes Nov 21, 2022

View reviewed changes

lcawl added the ui-copy Review of UI copy with docs team is recommended label Nov 21, 2022

lcawl reviewed Nov 21, 2022

View reviewed changes

Improve text

1b2dac7

Improve tags help text

de3a6a4

lcawl requested a review from a team as a code owner November 22, 2022 17:40

lcawl requested a review from maximpn November 22, 2022 17:40

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

c0ffa0e

…-ref HEAD~1..HEAD --fix'

lcawl reviewed Nov 23, 2022

View reviewed changes

banderror reviewed Nov 23, 2022

View reviewed changes

cnasikas added 4 commits November 23, 2022 11:55

Revert "Improve tags help text"

d024f42

This reverts commit de3a6a4.

Improve labels

23755db

Merge branch 'main' into fix_tags_label

1956a8e

Show the new tag item when adding a tag with spaces

b0fd46a

cnasikas enabled auto-merge (squash) November 23, 2022 11:22

cnasikas merged commit 6d9811e into elastic:main Nov 23, 2022

cnasikas deleted the fix_tags_label branch November 23, 2022 12:56

kibanamachine added the v8.7.0 label Nov 23, 2022

kibanamachine mentioned this pull request Nov 23, 2022

[8.6] [Cases] Enhance labels in the bulk edit tags flyout (#145811) #146142

Merged

kibanamachine added the v8.6.0 label Nov 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] Enhance labels in the bulk edit tags flyout #145811

[Cases] Enhance labels in the bulk edit tags flyout #145811

cnasikas commented Nov 21, 2022 •

edited by kibanamachine

Loading

elasticmachine commented Nov 21, 2022

elasticmachine commented Nov 21, 2022

adcoelho left a comment

mdefazio left a comment

cnasikas commented Nov 21, 2022

mdefazio left a comment

lcawl Nov 21, 2022 •

edited

Loading

cnasikas Nov 22, 2022

lcawl Nov 23, 2022

peteharverson commented Nov 22, 2022

cnasikas commented Nov 22, 2022

peteharverson commented Nov 22, 2022

lcawl commented Nov 22, 2022

cnasikas commented Nov 22, 2022

lcawl Nov 23, 2022

lcawl Nov 23, 2022

banderror Nov 23, 2022

cnasikas Nov 23, 2022

kibana-ci commented Nov 23, 2022

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented Nov 23, 2022

	defaultMessage: 'No tags available. Type to add one.',
	defaultMessage: 'No tags available. To add a tag, type it in the query bar.',

	defaultMessage: 'No tags available. To add a tag, type it in the query bar.',
	defaultMessage: 'No tags match your search.',

[Cases] Enhance labels in the bulk edit tags flyout #145811

[Cases] Enhance labels in the bulk edit tags flyout #145811

Conversation

cnasikas commented Nov 21, 2022 • edited by kibanamachine Loading

Summary

Screenshots

Checklist

For maintainers

elasticmachine commented Nov 21, 2022

elasticmachine commented Nov 21, 2022

adcoelho left a comment

Choose a reason for hiding this comment

mdefazio left a comment

Choose a reason for hiding this comment

cnasikas commented Nov 21, 2022

mdefazio left a comment

Choose a reason for hiding this comment

lcawl Nov 21, 2022 • edited Loading

Choose a reason for hiding this comment

cnasikas Nov 22, 2022

Choose a reason for hiding this comment

lcawl Nov 23, 2022

Choose a reason for hiding this comment

peteharverson commented Nov 22, 2022

cnasikas commented Nov 22, 2022

peteharverson commented Nov 22, 2022

lcawl commented Nov 22, 2022

cnasikas commented Nov 22, 2022

lcawl Nov 23, 2022

Choose a reason for hiding this comment

lcawl Nov 23, 2022

Choose a reason for hiding this comment

banderror Nov 23, 2022

Choose a reason for hiding this comment

cnasikas Nov 23, 2022

Choose a reason for hiding this comment

kibana-ci commented Nov 23, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented Nov 23, 2022

💚 All backports created successfully

Questions ?

cnasikas commented Nov 21, 2022 •

edited by kibanamachine

Loading

lcawl Nov 21, 2022 •

edited

Loading