Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change style of rule tags in alert details page #145946

Merged
merged 10 commits into from
Nov 23, 2022
Merged

Change style of rule tags in alert details page #145946

merged 10 commits into from
Nov 23, 2022

Conversation

benakansara
Copy link
Contributor

@benakansara benakansara commented Nov 21, 2022 •
edited by kibanamachine
Loading

Summary

Closes #141674

Styling of rule tags changed and some other minor style changes in Alert summary component of Alert details page.

Screenshot 2022-11-22 at 18 59 14

Screenshot 2022-11-22 at 18 57 24

Checklist

@benakansara benakansara marked this pull request as ready for review November 22, 2022 17:16
@benakansara benakansara added backport release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0 v8.7.0 labels Nov 22, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@benakansara benakansara requested a review from a team November 22, 2022 17:21
@benakansara benakansara added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport labels Nov 22, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 495.7KB 495.9KB +181.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

CoenWarmer
CoenWarmer approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benakansara benakansara merged commit 3e7d3ec into elastic:main Nov 23, 2022
@benakansara benakansara deleted the feat/change-rule-tags-design branch November 23, 2022 10:01
@kibanamachine kibanamachine mentioned this pull request Nov 23, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 23, 2022
@benakansara
Change style of rule tags in alert details page (elastic#145946)
eede398 
## Summary

Closes elastic#141674

Styling of rule tags changed and some other minor style changes in Alert
summary component of Alert details page.

<img width="1723" alt="Screenshot 2022-11-22 at 18 59 14"
src="https://user-images.githubusercontent.com/69037875/203387567-f4b7e89e-f075-4c2a-84fc-ac477cf5ba63.png">

<img width="1724" alt="Screenshot 2022-11-22 at 18 57 24"
src="https://user-images.githubusercontent.com/69037875/203387362-2cd7c549-09e2-4772-8de9-33aebfd6d428.png">

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: shahzad31 <shahzad.muhammad@elastic.co>
(cherry picked from commit 3e7d3ec)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 23, 2022
@kibanamachine @benakansara
[8.6] Change style of rule tags in alert details page (#145946) (#146118
e4baf88 
)

# Backport

This will backport the following commits from `main` to `8.6`:
- [Change style of rule tags in alert details page
(#145946)](#145946)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-23T10:01:29Z","message":"Change
style of rule tags in alert details page (#145946)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/141674\r\n\r\nStyling of rule
tags changed and some other minor style changes in Alert\r\nsummary
component of Alert details page.\r\n\r\n<img width=\"1723\"
alt=\"Screenshot 2022-11-22 at 18 59
14\"\r\nsrc=\"https://user-images.githubusercontent.com/69037875/203387567-f4b7e89e-f075-4c2a-84fc-ac477cf5ba63.png\">\r\n\r\n\r\n<img
width=\"1724\" alt=\"Screenshot 2022-11-22 at 18 57
24\"\r\nsrc=\"https://user-images.githubusercontent.com/69037875/203387362-2cd7c549-09e2-4772-8de9-33aebfd6d428.png\">\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
shahzad31
<shahzad.muhammad@elastic.co>","sha":"3e7d3ec2598821d034f18e13a343ec3dc994a5bc","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
Actionable
Observability","backport:prev-minor","v8.6.0","v8.7.0"],"number":145946,"url":"https://github.com/elastic/kibana/pull/145946","mergeCommit":{"message":"Change
style of rule tags in alert details page (#145946)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/141674\r\n\r\nStyling of rule
tags changed and some other minor style changes in Alert\r\nsummary
component of Alert details page.\r\n\r\n<img width=\"1723\"
alt=\"Screenshot 2022-11-22 at 18 59
14\"\r\nsrc=\"https://user-images.githubusercontent.com/69037875/203387567-f4b7e89e-f075-4c2a-84fc-ac477cf5ba63.png\">\r\n\r\n\r\n<img
width=\"1724\" alt=\"Screenshot 2022-11-22 at 18 57
24\"\r\nsrc=\"https://user-images.githubusercontent.com/69037875/203387362-2cd7c549-09e2-4772-8de9-33aebfd6d428.png\">\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
shahzad31
<shahzad.muhammad@elastic.co>","sha":"3e7d3ec2598821d034f18e13a343ec3dc994a5bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145946","number":145946,"mergeCommit":{"message":"Change
style of rule tags in alert details page (#145946)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/141674\r\n\r\nStyling of rule
tags changed and some other minor style changes in Alert\r\nsummary
component of Alert details page.\r\n\r\n<img width=\"1723\"
alt=\"Screenshot 2022-11-22 at 18 59
14\"\r\nsrc=\"https://user-images.githubusercontent.com/69037875/203387567-f4b7e89e-f075-4c2a-84fc-ac477cf5ba63.png\">\r\n\r\n\r\n<img
width=\"1724\" alt=\"Screenshot 2022-11-22 at 18 57
24\"\r\nsrc=\"https://user-images.githubusercontent.com/69037875/203387362-2cd7c549-09e2-4772-8de9-33aebfd6d428.png\">\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
shahzad31
<shahzad.muhammad@elastic.co>","sha":"3e7d3ec2598821d034f18e13a343ec3dc994a5bc"}}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoenWarmer CoenWarmer CoenWarmer approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make rule tags in Alert Details page to match with the design
6 participants
@benakansara @elasticmachine @kibana-ci @kibanamachine @CoenWarmer @shahzad31