[8.6] [Synthetics] Overview - standardize queries for monitor duration metric item (#145916) #146005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic item (elastic#145916) ## Summary Resolves elastic#145922 Resolves elastic#145270 Fixes a regression from elastic#143309 Standardizes the way the monitor duration metric is queried, ensuring that both monitor types, UI and Project, are queries in the same way. The changes were also carried into changes to the Monitor Flyout Before (duration for UI monitor shows, but not the duration for project monitors)  After (duration shows for both monitor types) <img width="1366" alt="Screen Shot 2022-11-21 at 2 39 09 PM" src="https://user-images.githubusercontent.com/11356435/203144056-d74617e5-6745-4c17-9a68-e5164f4be689.png"> ### Testing 1. Create at least one project monitor and one UI monitor 2. Ensure that both monitor types display the duration metric on the Overview page after running 3. In the actions popover, click edit monitor. Ensure the page redirects to the monitor edit page appropriately 4. In the actions popover, click go to monitor. Ensure that the page redirects to the monitor details page appropriately 5. In the actions popover, disable the monitor. Ensure it is successful. 6. In the actions popover, click inspect. Ensure the monitor flyout appears, then close the flyout. 7. Click on both monitor types, ensure the monitor flyout appears 8. Ensure the monitor duration metric appears in the monitor flyout 9. Ensure the last test run appears in the monitor flyout 10. Ensure both enable toggles work in the monitor flyout (in the body of the flyout and actions popover next to the flyout title) 11. Ensure the go to monitor link works in the monitor flyout actions popover next to the monitor title 12. Ensure the edit monitor link works in the monitor flyout actions popover next to the monitor title Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e8d77b3)
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Saved Objects .kibana field count
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.6:Questions ?
Please refer to the Backport tool documentation