Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix agent details after EUI upgrade #146073

Merged
merged 2 commits into from
Nov 23, 2022
Merged

[Fleet] Fix agent details after EUI upgrade #146073

merged 2 commits into from
Nov 23, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Nov 22, 2022 •
edited
Loading

Summary

Fix a padding issue with the latest EUI upgrade on the agent details page

It's easier to review with whitespace hidden https://github.com/elastic/kibana/pull/146073/files?w=1

UI change

Screen Shot 2022-11-22 at 4 30 58 PM

Bugged UI

Screen Shot 2022-11-22 at 4 30 12 PM

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0 labels Nov 22, 2022
@nchaulet nchaulet self-assigned this Nov 22, 2022
@nchaulet nchaulet requested a review from a team as a code owner November 22, 2022 21:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 889.6KB 889.6KB +70.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

juliaElastic
juliaElastic approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@juliaElastic juliaElastic merged commit d097d96 into elastic:main Nov 23, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 23, 2022
@nchaulet nchaulet deleted the fix-agent-details-padding branch November 23, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nchaulet @elasticmachine @kibana-ci @juliaElastic @kibanamachine