[Security Solution] UI Event Filters RBAC #146111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergoabraham
added
Team:Defend Workflows
gergoabraham
force-pushed
the
feat/olm-4917-ui-event-filters-ui-rbac
branch
from
2b93348
to
9ada0d8
Compare
9 tasks
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
paul-tavares
approved these changes
Nov 28, 2022
1 task
|
@elasticmachine merge upstream |
parkiino
approved these changes
Dec 1, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
gergoabraham
added a commit
that referenced
this pull request
Dec 11, 2022
## Summary Similarly to #145593 and #146111, this PR handles the None and Read privileges for the Blocklist sub-feature. The All privilege should not need any UI modification, but will need API modification. <img width="541" alt="image" src="https://user-images.githubusercontent.com/39014407/204349035-ca234eae-66ec-4018-bc04-8deaebdd8a0b.png"> The modification should: - hide Blocklist from Manage navigation items if privilege is NONE, - disable add/edit/delete for Blocklist if privilege is READ. - disable opening Policies from Blocklist (and any other `ArtifactListPage`) by disabling the links in the _'Applied for N policies'_ context menu For testing the last part: - add `Read` privilege for Blocklist (or any other artifact using `ArtifactListPage`), and `None` to Policies - for now, it has to be tested with `Fleet:All` and `Integrations:Read` privileges With `Policies:Read` privilege, hovering on the last item: <img width="773" alt="image" src="https://user-images.githubusercontent.com/39014407/205944360-fed60b11-7a88-42d5-93cd-307c7b34891b.png"> With `Policies:None` privilege, hovering on the last item: <img width="778" alt="image" src="https://user-images.githubusercontent.com/39014407/205944198-7dccfa37-177f-4eb7-a773-09eaeaa4b1fe.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
saarikabhasi
pushed a commit
to saarikabhasi/kibana
that referenced
this pull request
Dec 14, 2022
## Summary Similarly to elastic#145593 and elastic#146111, this PR handles the None and Read privileges for the Blocklist sub-feature. The All privilege should not need any UI modification, but will need API modification. <img width="541" alt="image" src="https://user-images.githubusercontent.com/39014407/204349035-ca234eae-66ec-4018-bc04-8deaebdd8a0b.png"> The modification should: - hide Blocklist from Manage navigation items if privilege is NONE, - disable add/edit/delete for Blocklist if privilege is READ. - disable opening Policies from Blocklist (and any other `ArtifactListPage`) by disabling the links in the _'Applied for N policies'_ context menu For testing the last part: - add `Read` privilege for Blocklist (or any other artifact using `ArtifactListPage`), and `None` to Policies - for now, it has to be tested with `Fleet:All` and `Integrations:Read` privileges With `Policies:Read` privilege, hovering on the last item: <img width="773" alt="image" src="https://user-images.githubusercontent.com/39014407/205944360-fed60b11-7a88-42d5-93cd-307c7b34891b.png"> With `Policies:None` privilege, hovering on the last item: <img width="778" alt="image" src="https://user-images.githubusercontent.com/39014407/205944198-7dccfa37-177f-4eb7-a773-09eaeaa4b1fe.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similarly to #145593, this PR handles the None and Read privileges for the Event Filters sub-feature. The All privilege should not need any UI modification, but will need API modification.
The modification should:
(note: it is still displayed for non-superusers, if the feature flag is disabled)update: it is hidden for non-superusers if the feature flag is disabledChecked:
Checklist
Delete any items that are not applicable to this PR.