-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAM] fix logger bug #146139
Merged
guskovaue
merged 1 commit into
elastic:main
from
guskovaue:RAM-146097-fix-logger-for-bulk-delete
Nov 24, 2022
Merged
[RAM] fix logger bug #146139
guskovaue
merged 1 commit into
elastic:main
from
guskovaue:RAM-146097-fix-logger-for-bulk-delete
Nov 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guskovaue
added
v8.6.0
release_note:fix
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
bug
Fixes for quality problems that affect the customer experience
labels
Nov 23, 2022
Pinging @elastic/response-ops (Team:ResponseOps) |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @guskovaue |
JiaweiWu
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
JiaweiWu
added
v8.7.0
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
Feature:Alerting/RulesManagement
Issues related to the Rules Management UX
release_note:skip
Skip the PR/issue when compiling release notes
and removed
release_note:fix
labels
Nov 24, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 24, 2022
Resolves: elastic#146097 ## Summary In this PR I'm fixing a bug for bulkDelete endpoint. It loggers this error message: `[2022-11-22T15:19:31.182+01:00][ERROR][plugins.alerting] Failure to delete schedules for underlying tasks:` even if we do not have any failed to delete tasks. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit ad8373c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 24, 2022
# Backport This will backport the following commits from `main` to `8.6`: - [[RAM] fix logger bug (#146139)](#146139) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia","email":"iuliia.guskova@elastic.co"},"sourceCommit":{"committedDate":"2022-11-24T08:24:19Z","message":"[RAM] fix logger bug (#146139)\n\nResolves: https://github.com/elastic/kibana/issues/146097\r\n\r\n## Summary\r\n\r\nIn this PR I'm fixing a bug for bulkDelete endpoint.\r\nIt loggers this error message:\r\n`[2022-11-22T15:19:31.182+01:00][ERROR][plugins.alerting] Failure to\r\ndelete schedules for underlying tasks:` even if we do not have any\r\nfailed to delete tasks.\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ad8373c46ff92537f655c095fe58bb634d946a7b","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Alerting/RulesManagement","backport:prev-minor","v8.6.0"],"number":146139,"url":"https://github.com/elastic/kibana/pull/146139","mergeCommit":{"message":"[RAM] fix logger bug (#146139)\n\nResolves: https://github.com/elastic/kibana/issues/146097\r\n\r\n## Summary\r\n\r\nIn this PR I'm fixing a bug for bulkDelete endpoint.\r\nIt loggers this error message:\r\n`[2022-11-22T15:19:31.182+01:00][ERROR][plugins.alerting] Failure to\r\ndelete schedules for underlying tasks:` even if we do not have any\r\nfailed to delete tasks.\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ad8373c46ff92537f655c095fe58bb634d946a7b"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia <iuliia.guskova@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
bug
Fixes for quality problems that affect the customer experience
Feature:Alerting/RulesManagement
Issues related to the Rules Management UX
release_note:skip
Skip the PR/issue when compiling release notes
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
v8.6.0
v8.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #146097
Summary
In this PR I'm fixing a bug for bulkDelete endpoint.
It loggers this error message:
[2022-11-22T15:19:31.182+01:00][ERROR][plugins.alerting] Failure to delete schedules for underlying tasks:
even if we do not have any failed to delete tasks.Checklist