Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] fix logger bug #146139

Merged

Conversation

guskovaue
Copy link
Contributor

@guskovaue guskovaue commented Nov 23, 2022

Resolves: #146097

Summary

In this PR I'm fixing a bug for bulkDelete endpoint.
It loggers this error message: [2022-11-22T15:19:31.182+01:00][ERROR][plugins.alerting] Failure to delete schedules for underlying tasks: even if we do not have any failed to delete tasks.

Checklist

@guskovaue guskovaue self-assigned this Nov 23, 2022
@guskovaue guskovaue added v8.6.0 release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) bug Fixes for quality problems that affect the customer experience labels Nov 23, 2022
@guskovaue guskovaue marked this pull request as ready for review November 23, 2022 12:42
@guskovaue guskovaue requested a review from a team as a code owner November 23, 2022 12:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @guskovaue

Copy link
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JiaweiWu JiaweiWu added v8.7.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Nov 24, 2022
@guskovaue guskovaue merged commit ad8373c into elastic:main Nov 24, 2022
@guskovaue guskovaue added v8.7.0 and removed v8.7.0 labels Nov 24, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 24, 2022
Resolves: elastic#146097

## Summary

In this PR I'm fixing a bug for bulkDelete endpoint.
It loggers this error message:
`[2022-11-22T15:19:31.182+01:00][ERROR][plugins.alerting] Failure to
delete schedules for underlying tasks:` even if we do not have any
failed to delete tasks.

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit ad8373c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 24, 2022
# Backport

This will backport the following commits from `main` to `8.6`:
- [[RAM] fix logger bug
(#146139)](#146139)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Julia","email":"iuliia.guskova@elastic.co"},"sourceCommit":{"committedDate":"2022-11-24T08:24:19Z","message":"[RAM]
fix logger bug (#146139)\n\nResolves:
https://github.com/elastic/kibana/issues/146097\r\n\r\n##
Summary\r\n\r\nIn this PR I'm fixing a bug for bulkDelete
endpoint.\r\nIt loggers this error
message:\r\n`[2022-11-22T15:19:31.182+01:00][ERROR][plugins.alerting]
Failure to\r\ndelete schedules for underlying tasks:` even if we do not
have any\r\nfailed to delete tasks.\r\n\r\n### Checklist\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ad8373c46ff92537f655c095fe58bb634d946a7b","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Alerting/RulesManagement","backport:prev-minor","v8.6.0"],"number":146139,"url":"https://github.com/elastic/kibana/pull/146139","mergeCommit":{"message":"[RAM]
fix logger bug (#146139)\n\nResolves:
https://github.com/elastic/kibana/issues/146097\r\n\r\n##
Summary\r\n\r\nIn this PR I'm fixing a bug for bulkDelete
endpoint.\r\nIt loggers this error
message:\r\n`[2022-11-22T15:19:31.182+01:00][ERROR][plugins.alerting]
Failure to\r\ndelete schedules for underlying tasks:` even if we do not
have any\r\nfailed to delete tasks.\r\n\r\n### Checklist\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ad8373c46ff92537f655c095fe58bb634d946a7b"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Julia <iuliia.guskova@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0 v8.7.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[RAM] Fix logger message for bulk delete
5 participants