Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[console] assorted autocomplete fixes #14770

Merged
merged 6 commits into from
Nov 10, 2017
Merged

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Nov 3, 2017

Fixes several small autocomplete changes

  1. add minimum_should_match to match query
  2. remove lowercase_expanded_terms
  3. source include and exclude is deprecated in favor of the plural form
  4. rollover api
  5. add extended_bounds to histogram and date_histogram aggregations

Closes #10841
Closes #10840
Closes #10071
Closes #8930
Closes #9651
Closes #8790

Release Notes: Fixes several autocomplete options in Console.

@jbudz
Copy link
Member Author

jbudz commented Nov 7, 2017

https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-selenium/8397/consoleFull

 fail: "visualize app tile map visualize app tile map chart should save with zoom level and load, take screenshot"
17:03:46        │        tryForTime timeout: [POST http://localhost:9515/session/4382285c639d6336f940e995e360ddae/element / {"using":"partial link text","value":"Visualization TileMap"}] no such element: Unable to locate element: {"method":"partial link text","selector":"Visualization TileMap"}

jenkins, test it

@jbudz
Copy link
Member Author

jbudz commented Nov 7, 2017

jenkins, test it

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tylersmalley
Copy link
Contributor

From what I can tell, all of these changes can be backported to 6.1

@jbudz jbudz merged commit 05f4ad0 into elastic:master Nov 10, 2017
jbudz added a commit that referenced this pull request Nov 10, 2017
* [console] add miminum_should_match to match query

* [console] source include,exclude -> includes,excludes

* [console] Remove lowercase expanded terms

* [console] _source_{include,exclude} -> _source_{includes,excludes}

* [console] autocomplete for rollover api

* [console] autocomplete for extended_bounds
@tylersmalley
Copy link
Contributor

@jbudz, can you add a release note to summarize these changes?

chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017
* [console] add miminum_should_match to match query

* [console] source include,exclude -> includes,excludes

* [console] Remove lowercase expanded terms

* [console] _source_{include,exclude} -> _source_{includes,excludes}

* [console] autocomplete for rollover api

* [console] autocomplete for extended_bounds
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017
* [console] add miminum_should_match to match query

* [console] source include,exclude -> includes,excludes

* [console] Remove lowercase expanded terms

* [console] _source_{include,exclude} -> _source_{includes,excludes}

* [console] autocomplete for rollover api

* [console] autocomplete for extended_bounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants