Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Rule is running #147896

Merged
merged 22 commits into from
Jan 10, 2023
Merged

[RAM] Rule is running #147896

merged 22 commits into from
Jan 10, 2023

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Dec 20, 2022 •
edited
Loading

Summary

#147759

Checklist

@XavierM XavierM added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0 labels Dec 20, 2022
mikecote
mikecote reviewed Dec 21, 2022
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

x-pack/plugins/alerting/server/rules_client/methods/bulk_disable.ts Outdated Show resolved Hide resolved
x-pack/plugins/alerting/server/rules_client/methods/disable.ts Outdated Show resolved Hide resolved
x-pack/plugins/alerting/server/task_runner/task_runner.ts Show resolved Hide resolved
x-pack/plugins/alerting/server/task_runner/running_handler.ts Outdated Show resolved Hide resolved
@XavierM XavierM marked this pull request as ready for review January 4, 2023 20:23
@XavierM XavierM requested a review from a team as a code owner January 4, 2023 20:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@XavierM XavierM added the release_note:skip Skip the PR/issue when compiling release notes label Jan 4, 2023
@XavierM XavierM requested a review from a team as a code owner January 4, 2023 21:12
mikecote
mikecote approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally in different scenarios and LGTM!

x-pack/plugins/alerting/server/task_runner/task_runner.ts
});
await this.ruleRunning.waitFor();
// eslint-disable-next-line no-empty
} catch {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: should we add a comment explaining why we're swallowing the error here?

x-pack/plugins/alerting/server/task_runner/running_handler.ts
public async waitFor(): Promise<void> {
this.stop();
if (this.isUpdating && this.runningPromise) return this.runningPromise;
else return Promise.resolve();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional nit:

Suggested change
else return Promise.resolve();

@XavierM XavierM enabled auto-merge (squash) January 9, 2023 20:35
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
alerting 420 421 +1

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
alert 99 100 +1
Unknown metric groups

API count

id before after diff
alerting 429 430 +1

ESLint disabled line counts

id before after diff
alerting 70 71 +1

Total ESLint disabled count

id before after diff
alerting 71 72 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit adbe6b7 into elastic:main Jan 10, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 10, 2023
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Jan 13, 2023
@XavierM @kibanamachine @jennypavlova
[RAM] Rule is running (elastic#147896)
ca1fc34 
## Summary

elastic#147759


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@maximpn maximpn mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@mikecote mikecote mikecote approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XavierM @elasticmachine @kibana-ci @pgayvallet @mikecote @kibanamachine