Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Posture] - Fixing CSP no fleet agent error #148632

Merged
merged 6 commits into from
Jan 10, 2023
Merged

[Cloud Posture] - Fixing CSP no fleet agent error #148632

merged 6 commits into from
Jan 10, 2023

Conversation

ofiriro3
Copy link
Contributor

Summary

In the past fleet wouldn't throw an error when the agent index wasn't found, today it throws.
We would like to catch this specific error in our plugin so the plugin behavior will remain the same

For maintainers

@ofiriro3 ofiriro3 marked this pull request as ready for review January 10, 2023 12:15
@ofiriro3 ofiriro3 requested review from a team as code owners January 10, 2023 12:15
@ofiriro3 ofiriro3 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Cloud Security Cloud Security team related 8.7 candidate labels Jan 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@ofiriro3 ofiriro3 linked an issue Jan 10, 2023 that may be closed by this pull request
When fleet agent index is not found Kibana throws an error #148281
Closed
@ofiriro3 ofiriro3 removed the request for review from a team January 10, 2023 13:02
orouz
orouz requested changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@orouz orouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes:
1 - remove changes on our FTR from this PR (done in another)
2 - define schema in module scope

x-pack/test/cloud_security_posture_functional/pages/findings.ts Outdated
@@ -32,7 +32,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const ruleName2 = data[1].rule.name;

// Failing: See https://github.com/elastic/kibana/issues/147998
describe.skip('Findings Page', () => {
describe('Findings Page', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove changes to this file, we're going to do it in a separate PR with a few other FTR changes as well.

x-pack/plugins/cloud_security_posture/server/lib/fleet_util.ts Outdated Show resolved Hide resolved
@ofiriro3 ofiriro3 requested a review from orouz January 10, 2023 16:00
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ofiriro3 ofiriro3 merged commit 72b9940 into elastic:main Jan 10, 2023
@ofiriro3 ofiriro3 mentioned this pull request Jan 11, 2023
Merged
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Jan 13, 2023
@ofiriro3 @jennypavlova
[Cloud Posture] - Fixing CSP no fleet agent error (elastic#148632)
12a2abf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orouz orouz orouz approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When fleet agent index is not found Kibana throws an error
6 participants
@ofiriro3 @elasticmachine @kibana-ci @orouz @kibanamachine @kfirpeled