Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Prepwork for EUI in Kibana #15436

Merged
merged 10 commits into from
Dec 12, 2017
Merged

WIP: Prepwork for EUI in Kibana #15436

merged 10 commits into from
Dec 12, 2017

Conversation

snide
Copy link
Contributor

@snide snide commented Dec 6, 2017

Small CSS reset fixes to prep Kibana for EUI.

@snide snide added the WIP Work in progress label Dec 6, 2017
@snide snide mentioned this pull request Dec 7, 2017
15 tasks
@cjcenizal cjcenizal force-pushed the eui/reset-css branch 2 times, most recently from d54538f to 0d8cbb9 Compare December 11, 2017 23:22
@cjcenizal
Copy link
Contributor

cjcenizal commented Dec 12, 2017

Filter bar

image

  • This seems to affect all ui-select instances. The placeholder text is too small.

Visualize

image

image

  • Space between the "Add Filter" button and the content after it (input label or "Advanced" accordion) needs to be bigger

image

  • There's extra padding added to the left of the "Show empty buckets" checkbox

image

  • The "Use CIDR Masks" button needs space beneath it

image

  • Needs more space above "Add" button

image

  • Needs more space below "Advanced" button

image

  • The label for the first input wraps, causing alignment to get thrown off

image

  • This error's text has really tight line-height, and the antialiasing treatment we apply to text makes it really hard to read

image

  • Does this gray text pass the color contrast checker?

image

  • The padding inside of this "Required" panel looks too tight
  • The space below the "Add Range" button is too tight

image

  • The Data Table vis options has too little space between labels and inputs

image

  • For the Coordinate Map vis, there's too little space between the checkboxes and the "Custom label" label

image

  • Not enough space between "Map type" label

image

  • Too tight spacing

image

  • TSVB annotations empty state spacing is too tight

image

  • TSVB markdown explanatory text has too-tight line-height

image

  • Input controls is missing space between the select and the button

image

  • Tag cloud is missing space between labels and inputs

Reporting

image

  • Too-tight spacing

Management

Index patterns

image

  • Space between labels in scripted field form is too tight
  • Warnings and help look kind of messed up, especially the code examples in the "Scripting Help" panel

Advanced settings

image

  • <td> element used to have vertical-align: middle but with this removed the cell content gets all messed up.

@snide
Copy link
Contributor Author

snide commented Dec 12, 2017

@cjcenizal got all of the above (minus the autocomplete one). Couldn't figure out how that code was constructed. Looks like the input just needs kuiTextInput on it.

@snide snide merged commit 452a62d into elastic:eui/reset-css Dec 12, 2017
@snide snide deleted the eui/css branch December 12, 2017 20:05
@snide snide removed the WIP Work in progress label Dec 12, 2017
@cjcenizal
Copy link
Contributor

Cross-referencing #15564 so there's a back-link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants