Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract fatal notification into fatalError service, add support for EuiToast notifications #15749

Merged
merged 38 commits into from
Jan 27, 2018
Merged

Extract fatal notification into fatalError service, add support for EuiToast notifications #15749

merged 38 commits into from
Jan 27, 2018

Commits on Jan 24, 2018

  1. Reorganize notify/lib files. Extract fatal notification into a fatalE… 

    …rror service.
    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    5b16537 View commit details
    Browse the repository at this point in the history

  2. Import Notifier from ui/notify module.

    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    25bde88 View commit details
    Browse the repository at this point in the history

  3. Convert notify/lib tests to use Jest.

    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    2ebadc7 View commit details
    Browse the repository at this point in the history

  4. Move kbn-notifications directive definition from directives.js to not… 

    …ify.js.
    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    45f4af1 View commit details
    Browse the repository at this point in the history

  5. Remove kbn-notifications directive import from typeahead.

    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    4db5249 View commit details
    Browse the repository at this point in the history

  6. Add basic mechanism for surfacing toasts.

    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    4a4943e View commit details
    Browse the repository at this point in the history

  7. Use toast notifications in Dashboard.

    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    adc1de5 View commit details
    Browse the repository at this point in the history

  8. Use toast notifications in Visualize.

    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    88c3051 View commit details
    Browse the repository at this point in the history

  9. Use toast notifications in Management.

    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    d3505f8 View commit details
    Browse the repository at this point in the history

  10. Extend toast lifetime to 6 seconds.

    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    e8038b1 View commit details
    Browse the repository at this point in the history

  11. Add tests for GlobalToastList. 

    - Remove uninitialized location variable.

Add unit tests for ToastNotifications.
    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    5ed6a71 View commit details
    Browse the repository at this point in the history

  12. Update state error handling test to assert against thrown error inste… 

    …ad of fatalError.

- Stub fatalErrorInternals.
    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    b26000b View commit details
    Browse the repository at this point in the history

  13. Temporarily skip failing tests. 

    - 6.0 shared dashboard URL BWC tests.
- Temporarily skip Dashboard queries tests.
- Temporarily skip Dashboard snapshot tests.
- Temporarily skip Dashboard panel controls tests.
- Temporarily skip more Dashboard panel controls tests.
- Temporarily skip Dashboard view edit tests.
- Temporarily skip all failing functional tests.
    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    3e8e8e6 View commit details
    Browse the repository at this point in the history

  14. Use single quotation marks when referring to a full name of an object.

    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    733070c View commit details
    Browse the repository at this point in the history

  15. Fix tests. 

    - Fix FilterBarClickHandler tests.
- Fix Dashboard bwc_shared_urls test.
- Fix Dashboard queries tests.
- Fix Dashboard snapshots and panel controls tests.
- Fix Dashboard view edit tests.
- Fix Dashboard tab tests.
- Fix Dashboard state tests.
- Fix Dashboard listing and time tests.
- Fix Dashboard bwc shared urls tests.
- Fix Visualize area chart, data table, line chart, pie chart, tag cloud, tile map, vertical bar chart, and heat map tests.
    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    dd1e3a6 View commit details
    Browse the repository at this point in the history

  16. Fix input control vis and markdown vis tests by configuring functiona… 

    …l test server to be in production mode.
    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    ee107e3 View commit details
    Browse the repository at this point in the history

  17. Fix Dashboard save tests.

    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    a5ae513 View commit details
    Browse the repository at this point in the history

  18. Last minute polish.

    @cjcenizal
    cjcenizal committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    6c26726 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. Use Chris's more efficient syntax.

    @cjcenizal
    cjcenizal committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    18da564 View commit details
    Browse the repository at this point in the history

  2. Add addSuccess, addWarning, and addDanger convenience methdos to Toas… 

    …tNotifications.
    @cjcenizal
    cjcenizal committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    818612b View commit details
    Browse the repository at this point in the history

  3. Update ToastNotifications to accept strings as well as objects.

    @cjcenizal
    cjcenizal committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    7763316 View commit details
    Browse the repository at this point in the history

  4. Remove all use cases of notify.info. Replace missing indices banner n… 

    …otification with a custom EuiCallOut.
    @cjcenizal
    cjcenizal committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    9dede7d View commit details
    Browse the repository at this point in the history

  5. Remove notify.info method.

    @cjcenizal
    cjcenizal committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    78bfe67 View commit details
    Browse the repository at this point in the history

  6. Auto-dismiss missingIndicesMessage after 15 seconds.

    @cjcenizal
    cjcenizal committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    bf0f4bb View commit details
    Browse the repository at this point in the history

  7. Rename missingIndicesMessage to createFirstIndexPatternPrompt.

    @cjcenizal
    cjcenizal committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    c37ae91 View commit details
    Browse the repository at this point in the history

  8. Remove unit tests for notifier info method.

    @cjcenizal
    cjcenizal committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    cb568ae View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2018

  1. Fix Dashboard and Saved Search test.

    @cjcenizal
    cjcenizal committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    7472600 View commit details
    Browse the repository at this point in the history

  2. Fix bug with toast dismissal logic.

    @cjcenizal
    cjcenizal committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    13bbfc4 View commit details
    Browse the repository at this point in the history

  3. Update testSubjects.exists to accept a timeout argument.

    @cjcenizal
    cjcenizal committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    9c42f06 View commit details
    Browse the repository at this point in the history

  4. Update toastNotifications.add to return the new toast.

    @cjcenizal
    cjcenizal committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    6404ba6 View commit details
    Browse the repository at this point in the history

  5. Add documentation on UI systems.

    @cjcenizal
    cjcenizal committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    81799fc View commit details
    Browse the repository at this point in the history

  6. Change 'No index pattern' prompt to use warning color.

    @cjcenizal
    cjcenizal committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    eaa1141 View commit details
    Browse the repository at this point in the history

  7. Fix discover functional tests.

    @cjcenizal
    cjcenizal committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    c89ad15 View commit details
    Browse the repository at this point in the history

  8. Add note on functional test use cases to docs.

    @cjcenizal
    cjcenizal committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    fb7d9e4 View commit details
    Browse the repository at this point in the history

  9. Improve structure of toast docs.

    @cjcenizal
    cjcenizal committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    545589d View commit details
    Browse the repository at this point in the history

  10. Increase functional test timeout to 3 minutes.

    @cjcenizal
    cjcenizal committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    e036a2d View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2018

  1. Skip some flaky tests.

    @cjcenizal
    cjcenizal committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    a990b0c View commit details
    Browse the repository at this point in the history

  2. Fix copy to clipboard tests.

    @cjcenizal
    cjcenizal committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    a898367 View commit details
    Browse the repository at this point in the history