Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slo): optimistic update #159208

Merged
merged 5 commits into from
Jun 8, 2023
Merged

fix(slo): optimistic update #159208

merged 5 commits into from
Jun 8, 2023

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Jun 7, 2023

📝 Summary

This PR fixes the optimistic updates

@kdelemme kdelemme self-assigned this Jun 7, 2023
@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0 labels Jun 7, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme marked this pull request as ready for review June 7, 2023 13:33
@kdelemme kdelemme requested a review from a team as a code owner June 7, 2023 13:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

kdelemme
kdelemme commented Jun 7, 2023
View reviewed changes
x-pack/plugins/observability/public/hooks/slo/use_create_slo.ts
Comment on lines -65 to -68
// Optimistically update to the new value
if (queryKey) {
queryClient.setQueryData(queryKey, optimisticUpdate);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By doing this, even if there was no entry in the queries cache, we add the new slo into the list page.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 909.6KB 909.8KB +207.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 497 501 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

@simianhacker simianhacker self-requested a review June 8, 2023 14:14
@kdelemme kdelemme merged commit 9d6846d into elastic:main Jun 8, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 8, 2023
@kdelemme kdelemme deleted the fix/optimistic-update branch June 8, 2023 20:29
saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Jun 14, 2023
@kdelemme @saarikabhasi
fix(slo): optimistic update (elastic#159208)
65cda72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees

@kdelemme kdelemme

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kdelemme @apmmachine @elasticmachine @kibana-ci @simianhacker @kibanamachine