[Lens] Add feature to ignore global filters at layer level #159248

dej611 · 2023-06-07T17:30:59Z

Summary

Fixes #143493

Add the switch control in Layer Settings
- Make sure it does not duplicate on Annotation Layer Settings
- Data Layers
- Reference line layers
- Extended dataView picker to support multiple icons
  - Added unit tests
- Functional tests

Create IgnoreGlobalFilter shared component folder
- Layer setting control component
- Info badge component
Extends esaggs_fn to support the flag
- Avoid to pass the filter to the handler if set
- Add unit tests
Notification badges
- Extends the badge component in Embeddable to support grouped messages
- Added unit tests

Add support for Open in Lens
- Add unit tests for each converter
- Functional tests

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
This was checked for cross-browser compatibility

dej611 · 2023-06-08T08:09:40Z

src/plugins/vis_types/timeseries/public/application/components/yes_no.tsx

@@ -23,7 +23,7 @@ export function YesNo({
  name,
  value,
  disabled,
-  'data-test-subj': dataTestSubj,
+  'data-test-subj': dataTestSubj = name,


Had to assign a default data-test-subj value to avoid having undefined-yes or undefined-no for all YesNo component on functional testing.
It should not affect existing tests as it only kicks in when the test id is not passed.

elasticmachine · 2023-06-09T07:07:25Z

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

stratoula

This works great Marco! Changes LGTM! I tested locally in Chrome with TSVB, TSVB with panel ignore, TSVB with layer ignore, annotations and all Lens scenarios and it works as expected!

jughosta

Data Discovery changes LGTM 👍

jughosta · 2023-06-09T08:20:12Z

x-pack/plugins/lens/public/shared_components/ignore_global_filter/settings_control.tsx

+    <EuiFormRow
+      display="columnCompressedSwitch"
+      label={i18n.translate('xpack.lens.layerSettings.ignoreGlobalFilters', {
+        defaultMessage: 'Use global filters',


Do we already use "global filters" naming in Kibana? Maybe it would be less confusing to say something like "Use search bar filters".

We are using the same terminology in TSVB (it supports this feature for many versions) so we used the same term for the TSVB to Lens users to easily identify it.

@gchaps I don't know if you have any proposal here to improve the text. We can still merge I think and we can change the text in a followup PR is we decide in favor of it.

Also the same terminology has been around in Lens for already few minor within the Annotation and Dashboard context.

kibana-ci · 2023-06-09T08:26:53Z

💚 Build Succeeded

Buildkite Build
Commit: 66ae25d

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`lens`	895	898	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`lens`	523	524	+1
`visualizations`	780	781	+1
total			+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	1.3MB	1.3MB	+2.1KB
`visTypeTimeseries`	507.9KB	508.3KB	+441.0B
total			+2.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	404.4KB	404.7KB	+246.0B
`visTypeGauge`	12.3KB	12.4KB	+46.0B
`visTypeHeatmap`	12.4KB	12.4KB	+23.0B
`visTypeMetric`	11.0KB	11.0KB	+23.0B
`visTypePie`	10.5KB	10.5KB	+23.0B
`visTypeTable`	18.0KB	18.0KB	+23.0B
`visTypeXy`	31.1KB	31.1KB	+46.0B
total			+430.0B

Unknown metric groups

API count

id	before	after	diff
`lens`	618	619	+1
`visualizations`	810	811	+1
total			+2

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	414	418	+4
`visTypeTimeseries`	19	22	+3
total			+9

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	498	502	+4
`visTypeTimeseries`	22	25	+3
total			+9

History

💚 Build #133794 succeeded c6c48a8
💔 Build #133755 failed 3ce3730
💔 Build #133716 failed 41f2753
💔 Build #133682 failed 0d31e11
💔 Build #133619 failed cf0ec80
💔 Build #133612 failed b3d8ca9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…59248) ## Summary Fixes elastic#143493 * Add the switch control in Layer Settings * [x] Make sure it does not duplicate on Annotation Layer Settings * [x] Data Layers * [x] Reference line layers * [x] Extended dataView picker to support multiple icons * [x] Added unit tests * [x] Functional tests <img width="351" alt="Screenshot 2023-06-07 at 15 28 19" src="https://github.com/elastic/kibana/assets/924948/00dc5523-0bec-4e9c-b1d0-4d36804b29f9"> <img width="340" alt="Screenshot 2023-06-07 at 15 31 31" src="https://github.com/elastic/kibana/assets/924948/d36ca147-5d8c-4123-9be3-2932844cbd15"> <img width="331" alt="Screenshot 2023-06-07 at 15 28 25" src="https://github.com/elastic/kibana/assets/924948/c7d4f166-b8ab-4439-a83c-debf82b913ad"> <img width="324" alt="Screenshot 2023-06-07 at 15 27 59" src="https://github.com/elastic/kibana/assets/924948/3738a7e0-6e49-4e22-b857-965a953b4b84"> <img width="323" alt="Screenshot 2023-06-07 at 15 27 53" src="https://github.com/elastic/kibana/assets/924948/5965bf1c-0e25-4c0e-b54f-fa315157fd44"> * Create `IgnoreGlobalFilter` shared component folder * [x] Layer setting control component * [x] Info badge component * Extends `esaggs_fn` to support the flag * [x] Avoid to pass the filter to the handler if set * [x] Add unit tests * Notification badges * [x] Extends the badge component in Embeddable to support grouped messages * [x] Added unit tests <img width="750" alt="Screenshot 2023-06-07 at 15 31 39" src="https://github.com/elastic/kibana/assets/924948/01bf8203-9133-4429-9b79-17ec67613c7e"> <img width="828" alt="Screenshot 2023-06-07 at 15 30 57" src="https://github.com/elastic/kibana/assets/924948/9acb78f2-d061-4225-a4af-b3a66e7454fc"> <img width="756" alt="Screenshot 2023-06-07 at 15 27 43" src="https://github.com/elastic/kibana/assets/924948/b9f79aed-7c02-4060-9c0f-61f438dc031d"> * Add support for Open in Lens * [x] Add unit tests for each converter * [x] Functional tests ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>

dej611 added 4 commits June 7, 2023 15:32

✨ Add flag to ignore filters

5e60c7d

🔧 Add ignore flag at layer level

648827d

♻️ Refactor UI for ignore global filters + tests

c1b65de

✨ Add support for open in lens transition

23450bd

dej611 added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens v8.9.0 labels Jun 7, 2023

✅ Add functional tests

47981b4

dej611 commented Jun 8, 2023

View reviewed changes

dej611 added 9 commits June 8, 2023 10:30

✅ Add more tests

24ebdd1

✅ Fix types and some functional tests

b3d8ca9

🔥 Remove unused translations

cf0ec80

✅ Fix failing tests

80b2494

🏷️ Fix types

0d31e11

🏷️ Fix types

41f2753

✅ Fix test

4e6684b

✅ Fix last test

3ce3730

🏷️ Fix types

c6c48a8

dej611 marked this pull request as ready for review June 9, 2023 07:07

dej611 requested review from a team as code owners June 9, 2023 07:07

Merge branch 'main' into feature/143493

66ae25d

stratoula approved these changes Jun 9, 2023

View reviewed changes

jughosta approved these changes Jun 9, 2023

View reviewed changes

dej611 merged commit e325d41 into elastic:main Jun 9, 2023

kibanamachine added the backport:skip This commit does not require backporting label Jun 9, 2023

stratoula mentioned this pull request Jun 22, 2023

[Dashboard] Add Ignore Global Filter Option to Panels #112328

Closed

dej611 mentioned this pull request Jul 18, 2023

[Lens] Provide a way to make the user aware of the current ignoreGlobalFilters state #142383

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens] Add feature to ignore global filters at layer level #159248

[Lens] Add feature to ignore global filters at layer level #159248

dej611 commented Jun 7, 2023 •

edited

Loading

dej611 Jun 8, 2023

elasticmachine commented Jun 9, 2023

stratoula left a comment

jughosta left a comment

jughosta Jun 9, 2023

stratoula Jun 9, 2023

dej611 Jun 9, 2023

kibana-ci commented Jun 9, 2023

API count

ESLint disabled line counts

Total ESLint disabled count

[Lens] Add feature to ignore global filters at layer level #159248

[Lens] Add feature to ignore global filters at layer level #159248

Conversation

dej611 commented Jun 7, 2023 • edited Loading

Summary

Checklist

dej611 Jun 8, 2023

Choose a reason for hiding this comment

elasticmachine commented Jun 9, 2023

stratoula left a comment

Choose a reason for hiding this comment

jughosta left a comment

Choose a reason for hiding this comment

jughosta Jun 9, 2023

Choose a reason for hiding this comment

stratoula Jun 9, 2023

Choose a reason for hiding this comment

dej611 Jun 9, 2023

Choose a reason for hiding this comment

kibana-ci commented Jun 9, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

dej611 commented Jun 7, 2023 •

edited

Loading