Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Update use of combobox icons #163118

Merged
merged 3 commits into from
Aug 7, 2023
Merged

[Synthetics] Update use of combobox icons #163118

merged 3 commits into from
Aug 7, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 3, 2023 •
edited
Loading

Summary

Since EUIComboBox supports prepend options now, so using that elastic/eui#6953

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 changed the title update icons [Synthetics] Update use of combobox icons Aug 7, 2023
@shahzad31 shahzad31 marked this pull request as ready for review August 7, 2023 10:32
@shahzad31 shahzad31 requested a review from a team as a code owner August 7, 2023 10:32
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.10.0 labels Aug 7, 2023
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Aug 7, 2023
@shahzad31
Update x-pack/plugins/synthetics/public/apps/synthetics/components/se…
a6683a2 
…ttings/alerting_defaults/connector_field.tsx
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

awahab07
awahab07 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 910.3KB 910.0KB -326.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 3eeed67 into elastic:main Aug 7, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 7, 2023
@shahzad31 shahzad31 deleted the icon branch August 7, 2023 12:04
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Aug 8, 2023
@shahzad31 @crespocarlos
[Synthetics] Update use of combobox icons (elastic#163118)
ed44906
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
@shahzad31 @bryce-b
[Synthetics] Update use of combobox icons (elastic#163118)
21b799e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awahab07 awahab07 awahab07 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shahzad31 @apmmachine @elasticmachine @kibana-ci @awahab07 @kibanamachine