Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky test #131192] HTTP SSL Redirects #163726

Merged
merged 2 commits into from
Aug 14, 2023
Merged

[Flaky test #131192] HTTP SSL Redirects #163726

merged 2 commits into from
Aug 14, 2023

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 11, 2023 •
edited by kibanamachine
Loading

Summary

Resolves #131192.

✅ Flaky test runner (400x): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2860

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Aug 11, 2023
@afharo afharo self-assigned this Aug 11, 2023
@afharo afharo marked this pull request as ready for review August 13, 2023 07:55
@afharo afharo requested a review from a team as a code owner August 13, 2023 07:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo requested a review from a team August 13, 2023 07:57
afharo
afharo commented Aug 14, 2023
View reviewed changes
test/server_integration/http/ssl_redirect/index.ts

// Skips because the current version of supertest cannot follow redirects
// Can be unskipped once https://github.com/elastic/kibana/pull/163716 is merged
it.skip('does not boot-loop (2nd redirect points to the landing page)', async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being pedantically explicit, this 2nd check didn't test what the previous claimed (redirecting to the https port). That's why I split it to a different test.

Then, I found out the issue with the old library of supertest, and I had to skip it.

@afharo afharo enabled auto-merge (squash) August 14, 2023 15:19
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

@afharo afharo merged commit 2611863 into elastic:main Aug 14, 2023
@afharo afharo deleted the flaky-131192 branch August 14, 2023 16:48
@kibanamachine kibanamachine mentioned this pull request Aug 14, 2023
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 163726

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 14, 2023
@afharo
[Flaky test elastic#131192] HTTP SSL Redirects (elastic#163726)
b17daa0 
(cherry picked from commit 2611863)
kibanamachine added a commit that referenced this pull request Aug 14, 2023
@kibanamachine @afharo
[8.9] [Flaky test #131192] HTTP SSL Redirects (#163726) (#163846)
7955df4 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Flaky test #131192] HTTP SSL Redirects
(#163726)](#163726)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-08-14T16:48:45Z","message":"[Flaky
test #131192] HTTP SSL Redirects
(#163726)","sha":"261186313e93661c93e214b7dc9a26ba0aa5b749","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","technical
debt","release_note:skip","backport:all-open","v8.10.0"],"number":163726,"url":"https://github.com/elastic/kibana/pull/163726","mergeCommit":{"message":"[Flaky
test #131192] HTTP SSL Redirects
(#163726)","sha":"261186313e93661c93e214b7dc9a26ba0aa5b749"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163726","number":163726,"mergeCommit":{"message":"[Flaky
test #131192] HTTP SSL Redirects
(#163726)","sha":"261186313e93661c93e214b7dc9a26ba0aa5b749"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
@mistic mistic added v8.9.2 and removed v8.9.1 labels Aug 17, 2023
bryce-b pushed a commit that referenced this pull request Aug 17, 2023
@afharo @bryce-b
[Flaky test #131192] HTTP SSL Redirects (#163726)
32bc053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees

@afharo afharo

Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture v8.9.2 v8.10.0
Projects
None yet
Milestone
No milestone
6 participants
@afharo @elasticmachine @kibana-ci @kibanamachine @jbudz @mistic