Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Data Frame Analytics trained models: adds functional tests for 'Deploy Model' action #163886

Merged
merged 16 commits into from
Aug 24, 2023
Merged

[ML] Data Frame Analytics trained models: adds functional tests for 'Deploy Model' action #163886

merged 16 commits into from
Aug 24, 2023

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Aug 14, 2023 •
edited by kibanamachine
Loading

Summary

Adds functional tests for deploy model action for DFA trained models with default config and with custom config.

Part of #160712

Flaky test run: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2961 (updated)

Checklist

@alvarezmelissa87 alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features Feature:Functional Testing v8.10.0 labels Aug 14, 2023
@alvarezmelissa87 alvarezmelissa87 self-assigned this Aug 14, 2023
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner August 14, 2023 20:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@alvarezmelissa87
Copy link
Contributor Author

The flaky test run has passed and this is ready for a look when you get a chance 🙏 cc @qn895, @darnautov

@alvarezmelissa87 alvarezmelissa87 requested review from peteharverson and removed request for darnautov August 21, 2023 12:50
@alvarezmelissa87
Copy link
Contributor Author

alvarezmelissa87 commented Aug 21, 2023 •
edited
Loading

@peteharverson, @darnautov - would you be up for taking a look when you get a chance? 🙏

@alvarezmelissa87 alvarezmelissa87 requested review from darnautov and removed request for qn895 August 21, 2023 12:54
@peteharverson peteharverson mentioned this pull request Aug 21, 2023
Closed
13 tasks
@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

darnautov
darnautov reviewed Aug 23, 2023
View reviewed changes
x-pack/test/functional/services/ml/deploy_models_flyout.ts Outdated
Comment on lines 203 to 206
inferenceConfig: any;
editedInferenceConfig?: any;
fieldMap: any;
editedFieldMap?: any;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please provide types here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 001a830

x-pack/test/functional/services/ml/deploy_models_flyout.ts Outdated
await this.deployModelsContinue('mlTrainedModelsInferenceReviewAndCreateStep');
}

public async completeTrainedModelsInferenceFlyoutCreateStep(expectedConfig: any) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 001a830

x-pack/test/functional/services/ml/deploy_models_flyout.ts Outdated

export type MlDeployTrainedModelsFlyout = ProvidedType<typeof DeployTrainedModelsFlyoutProvider>;

export function DeployTrainedModelsFlyoutProvider(
Copy link
Contributor

@darnautov darnautov Aug 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt?

Suggested change
export function DeployTrainedModelsFlyoutProvider(
export function DeployDFAModelFlyoutProvider(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 001a830

x-pack/test/functional/services/ml/index.ts Outdated
@@ -158,6 +159,7 @@ export function MachineLearningProvider(context: FtrProviderContext) {
const swimLane = SwimLaneProvider(context);
const trainedModels = TrainedModelsProvider(context, commonUI);
const trainedModelsTable = TrainedModelsTableProvider(context, commonUI, trainedModels);
const trainedModelsFlyout = DeployTrainedModelsFlyoutProvider(context, commonUI);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const trainedModelsFlyout = DeployTrainedModelsFlyoutProvider(context, commonUI);
const deployDFAModelFlyout = DeployTrainedModelsFlyoutProvider(context, commonUI);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 001a830

darnautov
darnautov approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +2.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit b2308a9 into elastic:main Aug 24, 2023
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-deploy-models-functional-tests branch August 24, 2023 19:19
@kibanamachine kibanamachine mentioned this pull request Aug 24, 2023
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 24, 2023
@alvarezmelissa87
[ML] Data Frame Analytics trained models: adds functional tests for '…
e5534cc 
…Deploy Model' action (elastic#163886)

## Summary

Adds functional tests for deploy model action for DFA trained models
with default config and with custom config.

Part of elastic#160712

Flaky test run:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2961
(updated)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b2308a9)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Sep 28, 2023
Merged
8 tasks
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 25, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

7 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 163886 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 163886 locally

@walterra walterra added the backport:skip This commit does not require backporting label Sep 30, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024
@walterra
Copy link
Contributor

Added backport:skip label to mute "backport missing" notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
backport:skip This commit does not require backporting Feature:Data Frame Analytics ML data frame analytics features Feature:Functional Testing :ml release_note:skip Skip the PR/issue when compiling release notes v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alvarezmelissa87 @elasticmachine @kibana-ci @kibanamachine @walterra @darnautov @peteharverson