Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] API integration tests for model_management endpoints #164668

Merged

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Aug 24, 2023

Summary

Part of #160712

  • Adds API integration tests for /model_management/nodes_overview and /model_management/memory_usage endpoints.

Also adds an API integration test for /trained_models/_stats.

Checklist

@darnautov darnautov added :ml test_api release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.10.0 v8.11.0 labels Aug 24, 2023
@darnautov darnautov self-assigned this Aug 24, 2023
@darnautov darnautov requested a review from a team as a code owner August 24, 2023 08:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a couple of typos, LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@darnautov darnautov merged commit b3f036b into elastic:main Aug 24, 2023
@darnautov darnautov deleted the ml-160712-trained-models-stats-api-tests branch August 24, 2023 17:32
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 24, 2023
kibanamachine added a commit that referenced this pull request Aug 24, 2023
…164668) (#164764)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[ML] API integration tests for `model_management` endpoints
(#164668)](#164668)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-08-24T17:32:34Z","message":"[ML]
API integration tests for `model_management` endpoints
(#164668)","sha":"b3f036b554600ae5f6ce330c91b4829636267ff5","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_api","release_note:skip","Team:ML","v8.10.0","v8.11.0"],"number":164668,"url":"https://github.com/elastic/kibana/pull/164668","mergeCommit":{"message":"[ML]
API integration tests for `model_management` endpoints
(#164668)","sha":"b3f036b554600ae5f6ce330c91b4829636267ff5"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164668","number":164668,"mergeCommit":{"message":"[ML]
API integration tests for `model_management` endpoints
(#164668)","sha":"b3f036b554600ae5f6ce330c91b4829636267ff5"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) test_api v8.10.0 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants