-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] API integration tests for model_management
endpoints
#164668
[ML] API integration tests for model_management
endpoints
#164668
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a couple of typos, LGTM
x-pack/test/api_integration/apis/ml/model_management/memory_usage.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/model_management/nodes_overview.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @darnautov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…164668) (#164764) # Backport This will backport the following commits from `main` to `8.10`: - [[ML] API integration tests for `model_management` endpoints (#164668)](#164668) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-08-24T17:32:34Z","message":"[ML] API integration tests for `model_management` endpoints (#164668)","sha":"b3f036b554600ae5f6ce330c91b4829636267ff5","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_api","release_note:skip","Team:ML","v8.10.0","v8.11.0"],"number":164668,"url":"https://github.com/elastic/kibana/pull/164668","mergeCommit":{"message":"[ML] API integration tests for `model_management` endpoints (#164668)","sha":"b3f036b554600ae5f6ce330c91b4829636267ff5"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164668","number":164668,"mergeCommit":{"message":"[ML] API integration tests for `model_management` endpoints (#164668)","sha":"b3f036b554600ae5f6ce330c91b4829636267ff5"}}]}] BACKPORT--> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Summary
Part of #160712
/model_management/nodes_overview
and/model_management/memory_usage
endpoints.Also adds an API integration test for
/trained_models/_stats
.Checklist