Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Field Formats] Unskip field formats Serverless tests #166409

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

davismcphee
Copy link
Contributor

@davismcphee davismcphee commented Sep 14, 2023

Summary

This PR unskips the field formats Serverless tests. I ran 100x flaky test runs against each project type to confirm they should no longer be flaky.

Flaky test runs:

Resolves #165537.
Resolves #165545.

Checklist

For maintainers

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) labels Sep 14, 2023
@davismcphee davismcphee self-assigned this Sep 14, 2023
@davismcphee davismcphee marked this pull request as ready for review September 15, 2023 20:57
@davismcphee davismcphee requested a review from a team as a code owner September 15, 2023 20:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

before(async () => {
// TODO: Serverless tests require login first
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: Serverless tests require login first
// Serverless tests require login first

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@davismcphee davismcphee merged commit 2234237 into elastic:main Sep 19, 2023
21 checks passed
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 19, 2023
@davismcphee davismcphee deleted the unskip-field-formats branch September 19, 2023 22:57
@watson watson added the Project:Serverless Work as part of the Serverless project for its initial release label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) v8.11.0
Projects
None yet
6 participants