-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Index Management] Fix encoding issue on index details page #166882
Merged
yuliacech
merged 18 commits into
elastic:main
from
yuliacech:im/details_page/fix_encoding
Sep 22, 2023
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8e3465e
[Index Management] Refactor the index details component to use a quer…
yuliacech c6f03de
Merge branch 'main' into im/details_page/fix_encoding
yuliacech a02fe8c
Merge branch 'main' into im/details_page/fix_encoding
yuliacech ecca38d
Merge branch 'main' into im/details_page/fix_encoding
yuliacech 96220f8
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 8a771d9
[Index Management] Update the limits.yml
yuliacech c26c536
Merge branch 'main' into im/details_page/fix_encoding
yuliacech a2138b0
[Index Management] Fix bundle size
yuliacech bf9b1fa
[Index Management] Fix imports
yuliacech ac4b8bc
Merge branch 'main' into im/details_page/fix_encoding
yuliacech 4f94f82
[Index Management] Fix imports
yuliacech bb799aa
[Index Management] Fix imports
yuliacech 15af942
Merge branch 'main' into im/details_page/fix_encoding
yuliacech 41debe7
Update x-pack/plugins/index_management/public/application/sections/ho…
yuliacech d3591e6
[Index Management] Add no index name message and prevent an http requ…
yuliacech 8eba5d3
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 820fb4a
Merge branch 'main' into im/details_page/fix_encoding
yuliacech 8064fa6
Merge branch 'main' into im/details_page/fix_encoding
yuliacech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
x-pack/plugins/index_management/common/constants/home_sections.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
export enum Section { | ||
Indices = 'indices', | ||
DataStreams = 'data_streams', | ||
IndexTemplates = 'templates', | ||
ComponentTemplates = 'component_templates', | ||
EnrichPolicies = 'enrich_policies', | ||
} | ||
|
||
export enum IndexDetailsSection { | ||
Overview = 'overview', | ||
Mappings = 'mappings', | ||
Settings = 'settings', | ||
Stats = 'stats', | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to extract these constants to a separate file in common folder so that it could be imported without increasing the bundle size.