-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(slo): prefill slo edit form on update error #168760
chore(slo): prefill slo edit form on update error #168760
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
1c69e6a
to
c586e34
Compare
24e421a
to
402490b
Compare
a75244f
to
32d097f
Compare
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
…-ref HEAD~1..HEAD --fix'
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #168759
Resolves #167986
🍒 Summary
This PR handles every SLO fields from the URL state for both the create and edit mode. The values in the URL state can be partially provided.
When an error happens during the update, we also redirect the user back to the form, while populating it with the previously entered values.
_a
query parameter_a
query parameter values merged with the default form values to populate the initial form values_a
query parameter merged with the default form values to populate the initial form values