Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(slo): prefill slo edit form on update error #168760

Merged
merged 11 commits into from
Oct 19, 2023

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Oct 12, 2023

Resolves #168759
Resolves #167986

🍒 Summary

This PR handles every SLO fields from the URL state for both the create and edit mode. The values in the URL state can be partially provided.
When an error happens during the update, we also redirect the user back to the form, while populating it with the previously entered values.

Flow URL _a query parameter Behaviour
Create present Use the _a query parameter values merged with the default form values to populate the initial form values
Create not present Use the default form values to populate the initial form values
Edit present Use the _a query parameter merged with the default form values to populate the initial form values
Edit not present Use the SLO values to populate the initial form values

@kdelemme kdelemme self-assigned this Oct 12, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Feature:SLO labels Oct 12, 2023
@kdelemme kdelemme force-pushed the fix/prefill-all-fields-slo-form branch from 1c69e6a to c586e34 Compare October 13, 2023 14:03
@kdelemme kdelemme force-pushed the fix/prefill-all-fields-slo-form branch from 24e421a to 402490b Compare October 13, 2023 14:42
@kdelemme kdelemme force-pushed the fix/prefill-all-fields-slo-form branch from a75244f to 32d097f Compare October 13, 2023 19:23
@kdelemme kdelemme marked this pull request as ready for review October 16, 2023 15:44
@kdelemme kdelemme requested a review from a team as a code owner October 16, 2023 15:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kdelemme kdelemme assigned simianhacker and unassigned kdelemme Oct 18, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #5 / Fields Browser Fields Browser rendering "before each" hook for "displays a search results label with the expected count of fields matching the filter input" "before each" hook for "displays a search results label with the expected count of fields matching the filter input"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB +836.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 101.3KB 101.3KB +70.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @simianhacker

Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdelemme kdelemme merged commit 32ba817 into elastic:main Oct 19, 2023
29 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 19, 2023
kpollich pushed a commit to kpollich/kibana that referenced this pull request Oct 19, 2023
benakansara pushed a commit to benakansara/kibana that referenced this pull request Oct 22, 2023
benakansara pushed a commit to benakansara/kibana that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:SLO release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLO] Pre-fill form when update SLO fails [SLO] Form handles all possible field from the url state
6 participants