Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybooks #169167

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix storybooks #169167

merged 1 commit into from
Oct 17, 2023

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Oct 17, 2023

@jbudz jbudz added release_note:skip Skip the PR/issue when compiling release notes ci:build-storybooks labels Oct 17, 2023
@jbudz jbudz marked this pull request as ready for review October 17, 2023 19:50
@jbudz jbudz requested review from a team as code owners October 17, 2023 19:50
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #5 / Fields Browser Editing the timeline "before each" hook for "removes the message field from the timeline when the user un-checks the field" "before each" hook for "removes the message field from the timeline when the user un-checks the field"
  • [job] [logs] FTR Configs #71 / InfraOps App Metrics UI Hosts View "after all" hook for "should be accessible from the Inventory page"
  • [job] [logs] FTR Configs #71 / InfraOps App Metrics UI Hosts View #Landing page Admin user "before each" hook for "as an admin, should be able to enable the hosts view feature"
  • [job] [logs] FTR Configs #19 / transform Accessibility for user with full Transform access "after all" hook in "for user with full Transform access"
  • [job] [logs] FTR Configs #19 / transform Accessibility for user with full Transform access "before all" hook in "for user with full Transform access"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4651 4645 -6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB -7.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Oct 17, 2023

I'm merging this early to fix CI. Please reach out if there are any concerns.

@jbudz jbudz merged commit 2932b77 into elastic:main Oct 17, 2023
43 of 44 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 17, 2023
@jbudz jbudz added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Oct 17, 2023
jbudz added a commit that referenced this pull request Oct 18, 2023
@jbudz
Copy link
Member Author

jbudz commented Oct 18, 2023

8.11: 86142a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:build-storybooks release_note:skip Skip the PR/issue when compiling release notes v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants