Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixes multi line truncation for id/description columns in job lists #169830

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Oct 25, 2023

Summary

Follow up to #165149.
Fixes #163147.

Makes use of EUI's new multi-line truncation option for table columns (elastic/eui#7226). For columns that use this feature, this PR wraps the text in custom render functions which add a span element with a title attribute and the cells text.

Checklist

@walterra walterra changed the title [ML] Transforms/DFA: Fixes multi line truncation for id/description columns in job lists [ML] Fixes multi line truncation for id/description columns in job lists Oct 27, 2023
@walterra walterra force-pushed the 163147-ml-multi-line-truncation branch from 7d86d68 to b309ea0 Compare October 27, 2023 05:47
@walterra walterra added :ml Feature:Transforms ML transforms Feature:Data Frame Analytics ML data frame analytics features Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis release_note:skip Skip the PR/issue when compiling release notes v8.12.0 labels Oct 27, 2023
@walterra walterra marked this pull request as ready for review October 27, 2023 05:49
@walterra walterra requested a review from a team as a code owner October 27, 2023 05:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 588.3KB 588.2KB -57.0B
ml 3.5MB 3.5MB +102.0B
transform 402.6KB 402.7KB +111.0B
total +156.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra merged commit 3ea90b3 into elastic:main Oct 30, 2023
38 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 30, 2023
@walterra walterra deleted the 163147-ml-multi-line-truncation branch October 30, 2023 12:22
fkanout pushed a commit to fkanout/kibana that referenced this pull request Oct 30, 2023
…sts (elastic#169830)

Makes use of EUI's new multi-line truncation option for table columns
(elastic/eui#7226). For columns that use this
feature, this PR wraps the text in custom render functions which add a
`span` element with a `title` attribute and the cells text.
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Oct 30, 2023
…sts (elastic#169830)

Makes use of EUI's new multi-line truncation option for table columns
(elastic/eui#7226). For columns that use this
feature, this PR wraps the text in custom render functions which add a
`span` element with a `title` attribute and the cells text.
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Oct 31, 2023
…sts (elastic#169830)

Makes use of EUI's new multi-line truncation option for table columns
(elastic/eui#7226). For columns that use this
feature, this PR wraps the text in custom render functions which add a
`span` element with a `title` attribute and the cells text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Frame Analytics ML data frame analytics features Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis Feature:Transforms ML transforms :ml release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Improve display for long descriptions in transforms and jobs
6 participants