-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security AI Assistant] Update anonymization privileges #180732
[Security AI Assistant] Update anonymization privileges #180732
Conversation
…nt-update-anonymization-priviledge
@YulNaumenko @spong, I think this looks great. Perhaps the wording could be improved a bit to show that it's field selection and anonymization. Also, since this will also effect insights, we should probably update the main title (Elastic AI Assistant) to reflect that? For the feature privilege itself - Maybe the name/title would be: "Field Selection and Anonymization" Description: "Change the default fields that are allowed to be used by the AI Assistant and AI Insights. Anonymize any of the content for the selected fields". For the text next to the tick box, maybe: "Allow changes", unless we want to also go for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 7d3fd66
For now, till the new design will be ready, I just removed toolbar, because no sense to have bulk actions and select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule management changes LGTM
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: |
Added new sub-feature to AI-Assistant which allows to grant user role privilege to edit Anonymization fields:
How to test:
How it looks when no privilege for the user role:
@patrykkopycinski please adopt it after merging this PR to the new UX