-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alert details page] Fix metric threshold chart time range for bigger lookback windows #184409
[Alert details page] Fix metric threshold chart time range for bigger lookback windows #184409
Conversation
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
{ | ||
defaultMessage: 'Threshold breached', | ||
{rule.params.criteria.map((criterion, index) => { | ||
const timeRange = getPaddedAlertTimeRange( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this section, I only added timeRange
and removed FormattedMessage
related to Last {lookback} {timeLabel}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maryam-saeidi, I have created a rule with 3 hours lookback window. And after 7 minutes of the trigger time, still can't see the alert annotation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested many lookback windows with different values and the bucket size in chart was always matching the rule lookback time. 💪🏻 !
@fkanout Good catch! It seems it happens due to the gap between last aggregated data and alert annotation:
|
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Canvas Sharable Runtime
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue I mentioned -missing alert annotation is already exists and not related to the PR.
So I approve this one and fix the other issue in a separate one. Thanks @maryam-saeidi for creating the issue.
Fixes #183625
Fixes #183130
Summary
This PR fixes #183130 by removing
Last 1 minute
subtitle in the alert details pages of the metric and custom threshold rules.Also, it adjusts the chart time range by extending it at least 20 times the rule execution interval to avoid showing no data for bigger intervals such as 1 hour or 1 day.