Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metric threshold] Deprecate unsafe.alertDetails.metrics.enabled feature flag #186623

Merged

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Jun 21, 2024

Fixes #183489

It also removes the technical preview badge from the metric threshold alert details page.

Having this feature flag now gives you the following warning and even changing it to false will not have any impact:

[2024-06-21T17:09:01.688+02:00][WARN ][config.deprecation] You no longer need to configure "xpack.observability.unsafe.alertDetails.metrics.enabled".

@maryam-saeidi maryam-saeidi added the release_note:feature Makes this part of the condensed release notes label Jun 21, 2024
@maryam-saeidi maryam-saeidi self-assigned this Jun 21, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi
Copy link
Member Author

/ci

@maryam-saeidi maryam-saeidi marked this pull request as ready for review June 21, 2024 15:06
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner June 21, 2024 15:06
@maryam-saeidi maryam-saeidi added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:feature Makes this part of the condensed release notes labels Jun 21, 2024
Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Jun 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 24, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #17 / ColumnsPopover renders correctly a list of selected columns
  • [job] [logs] FTR Configs #87 / Observability Logs Explorer DataSourceSelector with installed integrations and uncategorized data streams when open on the integrations tab should display a list of installed integrations

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 288.2KB 288.0KB -230.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 142.3KB 142.4KB +62.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit 626f2b1 into elastic:main Jun 24, 2024
28 checks passed
@maryam-saeidi maryam-saeidi deleted the 183489-deprecate-feature-flag branch June 24, 2024 11:56
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alert details page][Metric threshold] Deprecate feature flag
6 participants