-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves the performance of the table ES|QL visualization #187142
Conversation
/ci |
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally and it works.
I've left some code comments as memory pressure would be nice to be removed as well for performance.
x-pack/plugins/lens/common/expressions/map_to_columns/map_to_columns_fn_textbased.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/lens/common/expressions/map_to_columns/map_to_columns_fn_textbased.ts
Outdated
Show resolved
Hide resolved
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Closes #187089
Fixes the performance of the ES|QL charts:
The ES|QL charts become imperformant for a big amount of fields. I am changing the implementation a bit in order to render (and hold to cache) only the fields that take part in the visualization and not all colums
Checklist