Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves the performance of the table ES|QL visualization #187142

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jun 28, 2024

Summary

Closes #187089

Fixes the performance of the ES|QL charts:

  • the panel
  • the table visualization

The ES|QL charts become imperformant for a big amount of fields. I am changing the implementation a bit in order to render (and hold to cache) only the fields that take part in the visualization and not all colums

Checklist

@stratoula
Copy link
Contributor Author

/ci

@stratoula stratoula added release_note:fix v8.15.0 Feature:Lens Feature:ES|QL ES|QL related features in Kibana Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 1, 2024
@stratoula stratoula marked this pull request as ready for review July 1, 2024 06:50
@stratoula stratoula requested a review from a team as a code owner July 1, 2024 06:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and it works.
I've left some code comments as memory pressure would be nice to be removed as well for performance.

@stratoula
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 1479 1480 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +411.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 49.4KB 49.8KB +332.0B
Unknown metric groups

async chunk count

id before after diff
lens 24 25 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit e73eb1d into elastic:main Jul 2, 2024
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ES|QL] dashboard panel with a many fields dataset crashes browser
5 participants