Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling] Fix TopN function total CPU value #188848

Merged
merged 4 commits into from
Jul 23, 2024
Merged

[Profiling] Fix TopN function total CPU value #188848

merged 4 commits into from
Jul 23, 2024

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Jul 22, 2024 •
edited by kibanamachine
Loading

closes #188511

Screenshot 2024-07-22 at 13 59 28 Screenshot 2024-07-22 at 14 55 50 15

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels Jul 22, 2024
@cauemarcondes cauemarcondes requested a review from a team as a code owner July 22, 2024 14:08
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 22, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jul 23, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 405.9KB 405.9KB -18.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 2ced941 into elastic:main Jul 23, 2024
26 of 27 checks passed
@cauemarcondes cauemarcondes deleted the profiling-fix-functions branch July 23, 2024 15:21
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 23, 2024
@cauemarcondes
[Profiling] Fix TopN function total CPU value (elastic#188848)
c65324b 
closes elastic#188511

<img width="2784" alt="Screenshot 2024-07-22 at 13 59 28"
src="https://github.com/user-attachments/assets/910ae596-ef22-4c18-b31f-7a9016e3b61d">
<img width="2756" alt="Screenshot 2024-07-22 at 14 55 50"
src="https://github.com/user-attachments/assets/66be5e9f-0d55-4b02-b97a-1425b6f0420c">
15

(cherry picked from commit 2ced941)
@kibanamachine kibanamachine mentioned this pull request Jul 23, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 23, 2024
@kibanamachine @cauemarcondes
[8.15] [Profiling] Fix TopN function total CPU value (#188848) (#188974)
8730a13 
# Backport

This will backport the following commits from `main` to `8.15`:
- [[Profiling] Fix TopN function total CPU value
(#188848)](#188848)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-07-23T15:21:08Z","message":"[Profiling]
Fix TopN function total CPU value (#188848)\n\ncloses
https://github.com/elastic/kibana/issues/188511\r\n\r\n<img
width=\"2784\" alt=\"Screenshot 2024-07-22 at 13 59
28\"\r\nsrc=\"https://github.com/user-attachments/assets/910ae596-ef22-4c18-b31f-7a9016e3b61d\">\r\n<img
width=\"2756\" alt=\"Screenshot 2024-07-22 at 14 55
50\"\r\nsrc=\"https://github.com/user-attachments/assets/66be5e9f-0d55-4b02-b97a-1425b6f0420c\">\r\n15","sha":"2ced9416d3b87ffbe247974724420e357d667035","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","v8.15.0","v8.16.0"],"title":"[Profiling]
Fix TopN function total CPU
value","number":188848,"url":"https://github.com/elastic/kibana/pull/188848","mergeCommit":{"message":"[Profiling]
Fix TopN function total CPU value (#188848)\n\ncloses
https://github.com/elastic/kibana/issues/188511\r\n\r\n<img
width=\"2784\" alt=\"Screenshot 2024-07-22 at 13 59
28\"\r\nsrc=\"https://github.com/user-attachments/assets/910ae596-ef22-4c18-b31f-7a9016e3b61d\">\r\n<img
width=\"2756\" alt=\"Screenshot 2024-07-22 at 14 55
50\"\r\nsrc=\"https://github.com/user-attachments/assets/66be5e9f-0d55-4b02-b97a-1425b6f0420c\">\r\n15","sha":"2ced9416d3b87ffbe247974724420e357d667035"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188848","number":188848,"mergeCommit":{"message":"[Profiling]
Fix TopN function total CPU value (#188848)\n\ncloses
https://github.com/elastic/kibana/issues/188511\r\n\r\n<img
width=\"2784\" alt=\"Screenshot 2024-07-22 at 13 59
28\"\r\nsrc=\"https://github.com/user-attachments/assets/910ae596-ef22-4c18-b31f-7a9016e3b61d\">\r\n<img
width=\"2756\" alt=\"Screenshot 2024-07-22 at 14 55
50\"\r\nsrc=\"https://github.com/user-attachments/assets/66be5e9f-0d55-4b02-b97a-1425b6f0420c\">\r\n15","sha":"2ced9416d3b87ffbe247974724420e357d667035"}}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

Assignees
No one assigned
Labels
ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UniversalProfiling: Wrong values shown in TopN functions view under "Total CPU"
6 participants
@cauemarcondes @obltmachine @kibana-ci @kibanamachine @crespocarlos @jennypavlova