Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid calling onApiAvailable until after factory.buildEmbeddable returns #189304

Merged
merged 3 commits into from
Jul 30, 2024
Merged

avoid calling onApiAvailable until after factory.buildEmbeddable returns #189304

merged 3 commits into from
Jul 30, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jul 26, 2024

Fix timing issue discovered while working on control group, #188701 (comment).

@nreese nreese requested a review from a team as a code owner July 26, 2024 16:23
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jul 26, 2024
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes project:embeddableRebuild v8.16.0 and removed Feature:Embedding Embedding content via iFrame labels Jul 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese requested a review from ThomThomson July 26, 2024 16:24
@nreese nreese changed the title avoid calling onApiAvailable until after factor buildEmbeddable returns avoid calling onApiAvailable until after factory.buildEmbeddable returns Jul 26, 2024
@nreese nreese mentioned this pull request Jul 26, 2024
Merged
ThomThomson
ThomThomson approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM! Good catch and thanks for the fix.

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jul 26, 2024
@nreese
Copy link
Contributor Author

nreese commented Jul 30, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 71.3KB 71.3KB -17.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit cb5dea2 into elastic:main Jul 30, 2024
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Embedding Embedding content via iFrame project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nreese @elasticmachine @kibana-ci @ThomThomson @kibanamachine