Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Improve stats BY suggestion to include pipe and comma operators #189458

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Jul 30, 2024

Summary

This PR improves BY suggestion to include pipe and comma operator for cases where there's a variable in the group by column.

Before:
image

After:
Screenshot 2024-07-30 at 11 03 08

Before:
Screenshot 2024-07-30 at 11 05 54

After:
Screenshot 2024-07-30 at 11 03 38

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@qn895 qn895 added Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Jul 30, 2024
@qn895 qn895 self-assigned this Jul 30, 2024
@qn895 qn895 changed the title [ES|QL] Improve BY suggestion to include pipe [ES|QL] Improve BY suggestion to include pipe and comma operators Jul 30, 2024
@qn895 qn895 requested a review from stratoula July 30, 2024 16:08
@qn895 qn895 marked this pull request as ready for review July 30, 2024 16:09
@qn895 qn895 requested a review from a team as a code owner July 30, 2024 16:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@qn895 qn895 changed the title [ES|QL] Improve BY suggestion to include pipe and comma operators [ES|QL] Improve stats BY suggestion to include pipe and comma operators Jul 30, 2024
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @qn895, works great! LGTM!

@qn895
Copy link
Member Author

qn895 commented Jul 31, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.3MB 3.3MB +172.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 merged commit 204db75 into elastic:main Jul 31, 2024
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:enhancement Team:ESQL ES|QL related features in Kibana v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants