Migrate Enterprise search plugin authc dependencies from security plugin to core security service #189713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
SiddharthMantri
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
efegurkan
reviewed
Aug 6, 2024
|
|
||
| const createResponse = await createApiKey(request, security, indexName, keyName); | ||
| const createResponse = await coreSecurity.authc.apiKeys.create({ |
There was a problem hiding this comment.
I would rather do the same changes in the createApiKey function as we have some tests there. Where if you change the place what is called rest should be same anyways.
There was a problem hiding this comment.
@efegurkan Sorry for the delayed response. Addressed in 883ea86
efegurkan
approved these changes
Aug 13, 2024
|
@elasticmachine merge upstream |
|
@SiddharthMantri are you going to merge or abandon this PR? |
|
@TinaHeiligers I haven't had the chance to get back to fixing the test imports. I'll get to it asap and merge it in |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #186574
Closes #189714
Background: This PR is an example of a plugin migrating away from depending on the Security plugin, which is a high-priority effort for the last release before 9.0. The Enterprise search plugin uses authc.apiKeys.create from the security plugin's start contract on the server side.
For more context, the PR which exposes the API keys service from core is here: #186910
This PR migrates the usage from the security plugin start contract to the core security service.