Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] Do not display a toast about missing provider when error is displayed #189866

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[Visualize] Do not display a toast about missing provider when error is displayed #189866

merged 1 commit into from
Aug 6, 2024

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Aug 5, 2024 •
edited
Loading

Summary

To reproduce:

  1. Trigger an error on visualize visualization on the dashboard. A quick way of doing it would be just to import this saved object, that creates a visualization on a dataview that doesn't exist.
  2. This toast appears:
Screenshot 2024-08-05 at 11 44 48

test_toast_bug.json

This PR fixes it (doesn't display the toast). Should we backport? 🤔

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.16.0 labels Aug 5, 2024
@mbondyra mbondyra requested a review from a team as a code owner August 5, 2024 09:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mbondyra mbondyra changed the title [Visualize]Fix do not display a notification about missing provider when error is displayed [Visualize]Fix do not display a toast about missing provider when error is displayed Aug 5, 2024
@mbondyra mbondyra changed the title [Visualize]Fix do not display a toast about missing provider when error is displayed [Visualize] Do not display a toast about missing provider when error is displayed Aug 5, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 293.1KB 293.2KB +74.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nickofthyme
nickofthyme approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@nickofthyme nickofthyme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm not sure about backporting, the toast logic was just added in #184608. The only reason to backport would be to fix the dark mode styling in the VisualizationError, if there even was any.

@mbondyra mbondyra merged commit 3cf66e1 into elastic:main Aug 6, 2024
29 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 6, 2024
@mbondyra mbondyra deleted the visualize/pass_providers branch August 6, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mbondyra @elasticmachine @kibana-ci @nickofthyme @kibanamachine