Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Entity Analytics] Tidy Asset Criticality API docs #190037

Merged
merged 12 commits into from
Aug 13, 2024

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Aug 7, 2024

Addresses: #190038

Summary

Tidy the asset criticality API docs after reviewing the doc previews for Serverless and ESS

@hop-dev hop-dev added release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team labels Aug 7, 2024
@hop-dev hop-dev self-assigned this Aug 7, 2024
@hop-dev hop-dev requested a review from a team as a code owner August 7, 2024 10:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@hop-dev
Copy link
Contributor Author

hop-dev commented Aug 8, 2024

@elasticmachine merge upstream

@hop-dev
Copy link
Contributor Author

hop-dev commented Aug 8, 2024

@elasticmachine merge upstream

Copy link
Contributor

@tiansivive tiansivive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hop-dev
Copy link
Contributor Author

hop-dev commented Aug 12, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev merged commit 919844d into elastic:main Aug 13, 2024
42 checks passed
@hop-dev hop-dev deleted the tidy-asset-criticality-docs branch August 13, 2024 14:30
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 13, 2024
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 13, 2024
**Addresses:** elastic#190038

## Summary

Tidy the asset criticality API docs after reviewing the doc previews for
[Serverless](https://bump.sh/per-solution-example/doc/security-solution-api-playground)
and
[ESS](https://bump.sh/per-solution-example/doc/security-solution-api-playground-ess)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants