[APM][Settings][Custom links] Default field filter option always present #190309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lways included in options
…lectOptions tests
iblancof
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
HistoryTo update your PR or re-run it, just comment with: cc @iblancof |
Comment on lines
+14
to
+29
| const options = { | ||
| default: { value: 'DEFAULT', text: 'Select field...' }, | ||
| serviceName: { value: 'service.name', text: 'service.name' }, | ||
| serviceEnvironment: { value: 'service.environment', text: 'service.environment' }, | ||
| transactionType: { value: 'transaction.type', text: 'transaction.type' }, | ||
| transactionName: { value: 'transaction.name', text: 'transaction.name' }, | ||
| }; | ||
|
|
||
| const filters: Record<string, Filter> = { | ||
| empty: { key: '', value: '' }, | ||
| default: { key: 'DEFAULT' as Filter['key'], value: '' }, | ||
| serviceName: { key: 'service.name', value: 'foo' }, | ||
| serviceEnvironment: { key: 'service.environment', value: 'foo' }, | ||
| transactionType: { key: 'transaction.type', value: 'foo' }, | ||
| transactionName: { key: 'transaction.name', value: 'foo' }, | ||
| }; |
iblancof
deleted the
189987-apm-settings-custom-links-filters-field-options
branch
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 13, 2024
…ent (elastic#190309) ## Summary Closes elastic#189987 It was discovered that when users manually select the default option (`Select field`) for the field input, the option would disappear in some scenarios, causing other input values to change automatically. This issue occurred specifically when the default option was selected manually by the user. This happens because as options are selected by the user, they are removed from the selection list to prevent duplicates. With the fix ([commit](elastic@985cdc5)) we are never removing the default option from the list. |Scenario|Before|After| |-|-|-| |Two filters|<img src="https://github.com/user-attachments/assets/2268b92f-e9be-4c06-aa74-5f2f003117d5" width="280"> |<img src="https://github.com/user-attachments/assets/278a4860-f691-4121-acb5-f61a76147b56" width="280">| |More than two filters|<img src="https://github.com/user-attachments/assets/23aeb355-4932-452d-a6a8-ed1a2ccba428" width="280">|<img src="https://github.com/user-attachments/assets/30d7978e-1ec0-4736-8163-64790831bba0" width="280">|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #189987
It was discovered that when users manually select the default option (
Select field) for the field input, the option would disappear in some scenarios, causing other input values to change automatically. This issue occurred specifically when the default option was selected manually by the user.This happens because as options are selected by the user, they are removed from the selection list to prevent duplicates.
With the fix (commit) we are never removing the default option from the list.