[Security Solution][Endpoint] Update the run_endpoint_agent dev script to support use of an API Key
#190449
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-tavares
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
pzl
approved these changes
Aug 20, 2024
szwarckonrad
approved these changes
Aug 20, 2024
ashokaditya
approved these changes
Aug 28, 2024
| @@ -62,6 +65,8 @@ export const cli = () => { | |||
| --username Optional. User name to be used for auth against elasticsearch and | |||
| kibana (Default: elastic). | |||
| --password Optional. Password associated with the username (Default: changeme) | |||
| --apiKey Optional. A Kibana API key to use for authz. When defined, 'username' | |||
There was a problem hiding this comment.
Q: I don't see code change that ignores username/password, or is it already baked in?
There was a problem hiding this comment.
@ashokaditya - yes, its backed into KbnClientExtended class above. When api key is defined, we remove the creds from the URL and also intercept the .request() calls and inject the API key header
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/x-pack/plugins/security_solution/scripts/endpoint/run_endpoint_agent.jswith a new optional argument:--apiKey--usernameand--passwordusername/passwordis not ideal