Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Measure overview page performance #191703

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 29, 2024

Summary

Measure overview page performance !!

also introduced the usePageReady hook in ebt-tooling !!

@shahzad31 shahzad31 requested review from a team as code owners August 29, 2024 08:29
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Aug 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Aug 29, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

<TestNowModeFlyoutContainer />
</InspectorContextProvider>
</div>
<PerformanceContextProvider>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 29, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: df5aed8
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-191703-df5aed8efbe5

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 654 655 +1
apm 1933 1934 +1
cloudSecurityPosture 709 710 +1
core 516 517 +1
dashboard 637 638 +1
dataQuality 162 163 +1
datasetQuality 295 296 +1
dataVisualizer 811 812 +1
discover 1030 1031 +1
esqlDataGrid 418 419 +1
eventAnnotationListing 642 643 +1
exploratoryView 255 256 +1
infra 1578 1579 +1
lens 1513 1514 +1
logsExplorer 619 620 +1
observability 1118 1119 +1
savedObjectsTagging 180 181 +1
securitySolution 5725 5726 +1
slo 899 900 +1
synthetics 1022 1096 +74
transform 512 513 +1
unifiedDocViewer 283 284 +1
total +95

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ebt-tools 24 28 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 632.7KB 632.9KB +149.0B
dashboard 547.3KB 547.7KB +382.0B
dataQuality 114.1KB 114.2KB +149.0B
dataVisualizer 811.0KB 811.2KB +149.0B
discover 855.8KB 856.0KB +191.0B
eventAnnotationListing 312.0KB 312.2KB +149.0B
exploratoryView 268.7KB 268.9KB +149.0B
lens 1.5MB 1.5MB +191.0B
securitySolution 18.0MB 18.0MB +149.0B
synthetics 938.7KB 1.0MB +86.9KB
transform 634.6KB 634.7KB +149.0B
total +88.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/ebt-tools 1 2 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 420.4KB 420.6KB +149.0B
savedObjectsTagging 22.7KB 22.9KB +149.0B
synthetics 37.0KB 37.0KB +1.0B
unifiedDocViewer 12.0KB 12.2KB +149.0B
total +448.0B
Unknown metric groups

API count

id before after diff
@kbn/ebt-tools 33 37 +4

async chunk count

id before after diff
synthetics 15 16 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just lovely! Thank you for doing this!

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice hooks

@shahzad31 shahzad31 merged commit b9072e3 into elastic:main Aug 29, 2024
33 checks passed
@shahzad31 shahzad31 deleted the perf-synthetics branch August 29, 2024 15:36
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 29, 2024
@shahzad31 shahzad31 added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Aug 30, 2024
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 191703

Questions ?

Please refer to the Backport tool documentation

@shahzad31
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Aug 30, 2024
## Summary

Measure overview page performance !!

also introduced the usePageReady hook in ebt-tooling !!

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b9072e3)

# Conflicts:
#	x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/synthetics_app.tsx
#	x-pack/plugins/observability_solution/synthetics/tsconfig.json
iblancof pushed a commit to iblancof/kibana that referenced this pull request Aug 30, 2024
## Summary

Measure overview page performance !!

also introduced the usePageReady hook in ebt-tooling !!

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
shahzad31 added a commit that referenced this pull request Sep 3, 2024
)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Synthetics] Measure overview page performance
(#191703)](#191703)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-08-29T15:36:37Z","message":"[Synthetics]
Measure overview page performance (#191703)\n\n## Summary\r\n\r\nMeasure
overview page performance !!\r\n\r\nalso introduced the usePageReady
hook in ebt-tooling !!\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b9072e31ecc56ebaf2bb8df6b576bba7501043ab","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"number":191703,"url":"https://github.com/elastic/kibana/pull/191703","mergeCommit":{"message":"[Synthetics]
Measure overview page performance (#191703)\n\n## Summary\r\n\r\nMeasure
overview page performance !!\r\n\r\nalso introduced the usePageReady
hook in ebt-tooling !!\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b9072e31ecc56ebaf2bb8df6b576bba7501043ab"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191703","number":191703,"mergeCommit":{"message":"[Synthetics]
Measure overview page performance (#191703)\n\n## Summary\r\n\r\nMeasure
overview page performance !!\r\n\r\nalso introduced the usePageReady
hook in ebt-tooling !!\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b9072e31ecc56ebaf2bb8df6b576bba7501043ab"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.15.1 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants