[Cloud Security] Host Name Misconfiguration Datagrid & Refactor CSP Plugin PHASE 1 #192114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt to do will be to remove all usage of the added constants and function on csp plugins and update the import to be from the package
|
/ci |
|
/ci |
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
animehart
added
the
release_note:skip
tiansivive
approved these changes
Sep 5, 2024
animehart
added
the
ci:project-deploy-security
|
/ci |
1 similar comment
|
/ci |
maxcold
approved these changes
Sep 6, 2024
| @@ -6,14 +6,15 @@ | |||
| */ | |||
|
|
|||
| import { renderHook, act } from '@testing-library/react-hooks/dom'; | |||
| import { useNavigateFindings, useNavigateVulnerabilities } from './use_navigate_findings'; | |||
| import { useNavigateVulnerabilities } from './use_navigate_findings'; | |||
| import { useNavigateFindings } from './use_navigate_findings'; | |||
There was a problem hiding this comment.
seems like the change is done by mistake, two imports from the same file
There was a problem hiding this comment.
Woops, you are right
| @@ -38,8 +38,6 @@ export const DETECTION_RULE_RULES_API_CURRENT_VERSION = '2023-10-31'; | |||
| export const CLOUD_SECURITY_POSTURE_PACKAGE_NAME = 'cloud_security_posture'; | |||
|
|
|||
| export const CDR_MISCONFIGURATIONS_DATA_VIEW_NAME = 'Latest Cloud Security Misconfigurations'; | |||
There was a problem hiding this comment.
even if we don't need this const for shared code, I'd move it too to avoid confusion, as CDR related constants belong together
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Sep 11, 2024
…lugin PHASE 1 (elastic#192114) ## Summary In an attempt to make Reviewing easier and more accurate, the implementation of Misconfiguration Data grid on Host.name flyout in Alerts Page will be split into 2 Phases Phase 1: Move Functions, Utils or Helpers, Hooks, constants to Package Phase 2: Implementing the feature This is Phase 1 of the process This PR also include a small bug fix mentioned here elastic#191677 (review) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In an attempt to make Reviewing easier and more accurate, the implementation of Misconfiguration Data grid on Host.name flyout in Alerts Page will be split into 2 Phases
Phase 1: Move Functions, Utils or Helpers, Hooks, constants to Package
Phase 2: Implementing the feature
This is Phase 1 of the process
This PR also include a small bug fix mentioned here #191677 (review)