[Response Ops][Alerting] Removing second call to load rule at end of rule execution #192402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @ymao1 |
ymao1
added
Feature:Alerting
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
1 task
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this pull request
Sep 13, 2024
…rule execution (elastic#192402) Resolves elastic#192396 ## Summary Removes second call to load rule at the end of the rule execution. This call was meant to get any changes to the rule schedule that users may have initiated during rule execution but there is a lot of overhead in loading a rule and any changes to the schedule would be captured during the next execution anyway. ## To Verify 1. Add some logging and a delay to rule execution after the initial rule load: ``` --- a/x-pack/plugins/alerting/server/task_runner/task_runner.ts +++ b/x-pack/plugins/alerting/server/task_runner/task_runner.ts @@ -684,6 +684,10 @@ export class TaskRunner< schedule = asErr(err); } + this.logger.info(`STARTING RULE EXECUTION`); + + await new Promise((r) => setTimeout(r, 30000)); + await withAlertingSpan('alerting:process-run-results-and-update-rule', () => ``` 2. Start Kibana and create a rule with a schedule of 3 minutes. 3. Wait for the rule to run and log, then change the schedule interval to something else. 4. The next execution of the rule should still occur 3 minutes later, and then further executions should occur on the new schedule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #192396
Summary
Removes second call to load rule at the end of the rule execution. This call was meant to get any changes to the rule schedule that users may have initiated during rule execution but there is a lot of overhead in loading a rule and any changes to the schedule would be captured during the next execution anyway.
To Verify