Revert "[Fleet] use @kbn/config-schema in Fleet API (Part 1) (#192447)" #192840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
the
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jillguyonnet
approved these changes
Sep 13, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
added
v9.0.0
backport:skip
juliaElastic
added a commit
that referenced
this pull request
Sep 13, 2024
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Sep 18, 2024
…#192447)" (elastic#192840) This reverts commit 1116ac6. Related to elastic#184685 There were a few issues reported by the security team (like elastic#192832) It seems we have gaps in the test coverage, and adding the response schemas to the code is impacting the API as it adds validation on the response objects. I'll reopen the pr with adding more test coverage to prevent other errors.
|
@juliaElastic this pull request has an |
This was already backported to 8.x branch here #192904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1116ac6.
Related to #184685
There were a few issues reported by the security team (like #192832)
It seems we have gaps in the test coverage, and adding the response schemas to the code is impacting the API as it adds validation on the response objects.
I'll reopen the pr with adding more test coverage to prevent other errors.